Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ilya's 2nd set comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h" 5 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 2258 matching lines...) Expand 10 before | Expand all | Expand 10 after
2269 void AutofillDialogControllerImpl::OnPopupHidden() {} 2269 void AutofillDialogControllerImpl::OnPopupHidden() {}
2270 2270
2271 bool AutofillDialogControllerImpl::ShouldRepostEvent( 2271 bool AutofillDialogControllerImpl::ShouldRepostEvent(
2272 const ui::MouseEvent& event) { 2272 const ui::MouseEvent& event) {
2273 DCHECK_NE(UNKNOWN_TYPE, popup_input_type_); 2273 DCHECK_NE(UNKNOWN_TYPE, popup_input_type_);
2274 // If the event would be reposted inside the input showing an Autofill popup, 2274 // If the event would be reposted inside the input showing an Autofill popup,
2275 // just ignore. 2275 // just ignore.
2276 return !view_->HitTestInput(popup_input_type_, event.location()); 2276 return !view_->HitTestInput(popup_input_type_, event.location());
2277 } 2277 }
2278 2278
2279 void AutofillDialogControllerImpl::DidSelectSuggestion(int identifier) { 2279 void AutofillDialogControllerImpl::DidSelectSuggestion(
2280 const base::string16& value,
2281 int identifier) {
2280 // TODO(estade): implement. 2282 // TODO(estade): implement.
2281 } 2283 }
2282 2284
2283 void AutofillDialogControllerImpl::DidAcceptSuggestion( 2285 void AutofillDialogControllerImpl::DidAcceptSuggestion(
2284 const base::string16& value, 2286 const base::string16& value,
2285 int identifier) { 2287 int identifier) {
2286 DCHECK_NE(UNKNOWN_TYPE, popup_input_type_); 2288 DCHECK_NE(UNKNOWN_TYPE, popup_input_type_);
2287 // Because |HidePopup()| can be called from |UpdateSection()|, remember the 2289 // Because |HidePopup()| can be called from |UpdateSection()|, remember the
2288 // type of the input for later here. 2290 // type of the input for later here.
2289 const ServerFieldType popup_input_type = popup_input_type_; 2291 const ServerFieldType popup_input_type = popup_input_type_;
(...skipping 1551 matching lines...) Expand 10 before | Expand all | Expand 10 after
3841 view_->UpdateButtonStrip(); 3843 view_->UpdateButtonStrip();
3842 } 3844 }
3843 3845
3844 void AutofillDialogControllerImpl::FetchWalletCookie() { 3846 void AutofillDialogControllerImpl::FetchWalletCookie() {
3845 net::URLRequestContextGetter* request_context = profile_->GetRequestContext(); 3847 net::URLRequestContextGetter* request_context = profile_->GetRequestContext();
3846 signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context)); 3848 signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context));
3847 signin_helper_->StartWalletCookieValueFetch(); 3849 signin_helper_->StartWalletCookieValueFetch();
3848 } 3850 }
3849 3851
3850 } // namespace autofill 3852 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698