Add "previewing on hover" support for single-field autocomplete input

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_manager.h"
@@ skipping 146 matching lines @@
 }
 
 void AutofillExternalDelegate::OnPopupHidden() {
 }
 
 bool AutofillExternalDelegate::ShouldRepostEvent(const ui::MouseEvent& event) {
   NOTREACHED();
   return true;
 }
 
-void AutofillExternalDelegate::DidSelectSuggestion(int identifier) {
+void AutofillExternalDelegate::DidSelectSuggestion(int identifier,
+                                                   const base::string16& value)
+{

[Ilya Sherman, 2014/02/22 05:59:51]

nit: The curly brace should be on the previous line.  If this causes the line to
exceed 80 characters in length, then the parameters should wrap.

[ziran.sun, 2014/02/27 15:38:11]

Done.

   ClearPreviewedForm();
 
   // Only preview the data if it is a profile.
   if (identifier > 0)
     FillAutofillFormData(identifier, true);
+  // Preview Autocomplete field

[Ilya Sherman, 2014/02/22 05:59:51]

nit: This comment is redundant with the code; please remove it.

+  else if (identifier == WebAutofillClient::MenuItemIDAutocompleteEntry) {
+    autofill_driver_->RendererShouldPreviewAutoCompleteNode(value);
+  }

[Ilya Sherman, 2014/02/22 05:59:51]

nit: No need for curly braces.

[ziran.sun, 2014/02/27 15:38:11]

Done.

 }
 
 void AutofillExternalDelegate::DidAcceptSuggestion(const base::string16& value,
                                                    int identifier) {
   if (identifier == WebAutofillClient::MenuItemIDAutofillOptions) {
     // User selected 'Autofill Options'.
     autofill_manager_->ShowAutofillSettings();
   } else if (identifier == WebAutofillClient::MenuItemIDClearForm) {
     // User selected 'Clear form'.
     autofill_driver_->RendererShouldClearFilledForm();
@@ skipping 166 matching lines @@
   // Set the values that all datalist elements share.
   autofill_icons->insert(autofill_icons->begin(),
                          data_list_values_.size(),
                          base::string16());
   autofill_unique_ids->insert(autofill_unique_ids->begin(),
                               data_list_values_.size(),
                               WebAutofillClient::MenuItemIDDataListEntry);
 }
 
 }  // namespace autofill