Add "previewing on hover" support for single-field autocomplete input

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 2136 matching lines @@
   DCHECK_NE(UNKNOWN_TYPE, popup_input_type_);
   // If the event would be reposted inside the input showing an Autofill popup,
   // just ignore.
   return !view_->HitTestInput(popup_input_type_, event.location());
 }
 
 void AutofillDialogControllerImpl::DidSelectSuggestion(int identifier) {
   // TODO(estade): implement.
 }
 
+void AutofillDialogControllerImpl::DidSelectAutocompleteSuggestion(
+    const base::string16& value) {
+  // TODO: inline with DidSelectSuggestion() implementation.
+}
+
 void AutofillDialogControllerImpl::DidAcceptSuggestion(
     const base::string16& value,
     int identifier) {
   DCHECK_NE(UNKNOWN_TYPE, popup_input_type_);
   // Because |HidePopup()| can be called from |UpdateSection()|, remember the
   // type of the input for later here.
   const ServerFieldType popup_input_type = popup_input_type_;
 
   ScopedViewUpdates updates(view_.get());
   const PersonalDataManager::GUIDPair& pair = popup_guids_[identifier];
@@ skipping 59 matching lines @@
 void AutofillDialogControllerImpl::RemoveSuggestion(
     const base::string16& value,
     int identifier) {
   // TODO(estade): implement.
 }
 
 void AutofillDialogControllerImpl::ClearPreviewedForm() {
   // TODO(estade): implement.
 }
 
+void AutofillDialogControllerImpl::ClearAutocompletePreviewedField() {
+  // TODO: inline with ClearPreviewedForm() implementation.

[Evan Stade, 2014/01/27 17:43:17]

TODOs need to have your name on them. That said, the new Autocomplete functions
don't make sense for the AutofillDialog. I think it's an intentional no-op, or
there should be a default no-op implementation.

[ziran.sun, 2014/01/27 18:18:06]

Done.

+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // content::NotificationObserver implementation.
 
 void AutofillDialogControllerImpl::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK_EQ(type, content::NOTIFICATION_NAV_ENTRY_COMMITTED);
   content::LoadCommittedDetails* load_details =
       content::Details<content::LoadCommittedDetails>(details).ptr();
@@ skipping 1401 matching lines @@
   view_->UpdateButtonStrip();
 }
 
 void AutofillDialogControllerImpl::FetchWalletCookie() {
   net::URLRequestContextGetter* request_context = profile_->GetRequestContext();
   signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context));
   signin_helper_->StartWalletCookieValueFetch();
 }
 
 }  // namespace autofill