Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1484093002: Allowing multiple SaveItems to have same URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nested-frames-more-involved-fix
Patch Set: Rebasing... Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/save_file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 1035804297b1eed093b6ff6cf9685b3aafaeef84..f327236deb07f38832f79f04d40a771e85de37c0 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -1109,9 +1109,20 @@ IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, RuntimeChanges) {
};
std::vector<std::string> expected_substrings(std::begin(arr), std::end(arr));
- // TODO(lukasza): crbug.com/106364: Fix complete-html mode as well.
- if (save_page_type == content::SAVE_PAGE_TYPE_AS_COMPLETE_HTML)
- return;
+ if (save_page_type == content::SAVE_PAGE_TYPE_AS_COMPLETE_HTML) {
+ // TODO(lukasza): crbug.com/106364: Expand complete-html test beyond just
+ // being a crash test. In particular, the |complete_html_arr| below should
+ // be the same as the |arr| above (and at this point the special-casing of
+ // complete-html can be removed).
+ // Draft CLs with fix proposals that should accomplish this:
+ // - crrev.com/1502563004
+ // - crrev.com/1500103002
+ std::string complete_html_arr[] = {
+ "frames-runtime-changes.htm: 4388232f-8d45-4d2e-9807-721b381be153",
+ };
+ expected_substrings = std::vector<std::string>(
+ std::begin(complete_html_arr), std::end(complete_html_arr));
+ }
GURL url(embedded_test_server()->GetURL(
"a.com", "/save_page/frames-runtime-changes.htm?do_runtime_changes=1"));
« no previous file with comments | « no previous file | content/browser/download/save_file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698