Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1484053002: CMake: generate skia.h and skia_{compile|link}_arguments.txt (Closed)

Created:
5 years ago by hal.canary
Modified:
5 years ago
Reviewers:
jcgregorio
CC:
mtklein, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMake: generate skia.h and skia_{compile|link}_arguments.txt Motivation: for use by fiddle. Also, add new files to .gitignore CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/d1c94a41589c62ffc3a84e51ddf63a623a77658c

Patch Set 1 #

Patch Set 2 : 2015-11-30 (Monday) 15:20:12 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -12 lines) Patch
M cmake/.gitignore View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cmake/CMakeLists.txt View 1 4 chunks +54 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484053002/1
5 years ago (2015-11-30 18:45:30 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 18:57:32 UTC) #5
hal.canary
PTAL
5 years ago (2015-11-30 19:01:06 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484053002/20001
5 years ago (2015-11-30 20:21:08 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 20:34:16 UTC) #12
jcgregorio
lgtm
5 years ago (2015-11-30 20:39:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484053002/20001
5 years ago (2015-11-30 20:42:07 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-30 20:43:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d1c94a41589c62ffc3a84e51ddf63a623a77658c

Powered by Google App Engine
This is Rietveld 408576698