Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/app_list/app_list_item.cc

Issue 148403007: Protect AppListItemList Add/Remove and fix sync bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/app_list_item.h ('k') | ui/app_list/app_list_item_list.h » ('j') | ui/app_list/cocoa/apps_grid_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/app_list_item.cc
diff --git a/ui/app_list/app_list_item.cc b/ui/app_list/app_list_item.cc
index 9d35f873275ff66a42d54e4425a4d48ce886eb47..70fe6bb3e91065d9bfd927c45c9982092d77bb67 100644
--- a/ui/app_list/app_list_item.cc
+++ b/ui/app_list/app_list_item.cc
@@ -88,6 +88,7 @@ ui::MenuModel* AppListItem::GetContextMenuModel() {
bool AppListItem::CompareForTest(const AppListItem* other) const {
return id_ == other->id_ &&
title_ == other->title_ &&
+ GetItemType() == other->GetItemType() &&
position_.Equals(other->position_);
}
« no previous file with comments | « ui/app_list/app_list_item.h ('k') | ui/app_list/app_list_item_list.h » ('j') | ui/app_list/cocoa/apps_grid_controller_unittest.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698