chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc - Issue 148403007: Protect AppListItemList Add/Remove and fix sync bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

Issue 148403007: Protect AppListItemList Add/Remove and fix sync bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/fast_show_pickler.cc ('k') | ui/app_list/app_list_folder_item.h » ('j') | ui/app_list/cocoa/apps_grid_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

diff --git a/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc b/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

index 4598e6a57a0a67faa5fae1afe8e73f136ac139e8..86357b9c77946c810cecf10e5f024f0a381cd270 100644

--- a/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

+++ b/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

@@ -78,7 +78,7 @@ TEST_F(AppListModelPicklerUnitTest, OneItem) {

AppListModel model;

AppListItem* app1 = new AppListItem("abc");

app1->SetTitleAndFullName("ht", "hello, there");

- model.item_list()->AddItem(app1);

+ model.AddItem(app1);

DoConsistencyChecks(&model);

}

@@ -87,11 +87,11 @@ TEST_F(AppListModelPicklerUnitTest, TwoItems) {

AppListModel model;

AppListItem* app1 = new AppListItem("abc");

app1->SetTitleAndFullName("ht", "hello, there");

- model.item_list()->AddItem(app1);

+ model.AddItem(app1);

AppListItem* app2 = new AppListItem("abc2");

app2->SetTitleAndFullName("ht2", "hello, there 2");

- model.item_list()->AddItem(app2);

+ model.AddItem(app2);

DoConsistencyChecks(&model);

}

@@ -101,11 +101,11 @@ TEST_F(AppListModelPicklerUnitTest, Images) {

AppListItem* app1 = new AppListItem("abc");

app1->SetTitleAndFullName("ht", "hello, there");

app1->SetIcon(MakeImage(), true);

- model.item_list()->AddItem(app1);

+ model.AddItem(app1);

AppListItem* app2 = new AppListItem("abc2");

app2->SetTitleAndFullName("ht2", "hello, there 2");

- model.item_list()->AddItem(app2);

+ model.AddItem(app2);

DoConsistencyChecks(&model);

}

@@ -115,7 +115,7 @@ TEST_F(AppListModelPicklerUnitTest, EmptyImage) {

AppListItem* app1 = new AppListItem("abc");

app1->SetTitleAndFullName("ht", "hello, there");

app1->SetIcon(gfx::ImageSkia(), true);

- model.item_list()->AddItem(app1);

+ model.AddItem(app1);

DoConsistencyChecks(&model);

}