Protect AppListItemList Add/Remove and fix sync bugs

chrome/browser/ui/app_list/extension_app_model_builder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/extension_app_model_builder.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/prefs/pref_service.h"
@@ skipping 87 matching lines @@
     const std::string& extension_id,
     int percent_downloaded) {
   ExtensionAppItem* item = GetExtensionAppItem(extension_id);
   if (!item)
     return;
   item->SetPercentDownloaded(percent_downloaded);
 }
 
 void ExtensionAppModelBuilder::OnInstallFailure(
     const std::string& extension_id) {
-  model_->item_list()->DeleteItem(extension_id);
+  model_->DeleteItem(extension_id);
 }
 
 void ExtensionAppModelBuilder::OnExtensionLoaded(const Extension* extension) {
   if (!extension->ShouldDisplayInAppLauncher())
     return;
 
   DVLOG(2) << service_ << ": OnExtensionLoaded: "
            << extension->id().substr(0, 8);
   ExtensionAppItem* existing_item = GetExtensionAppItem(extension->id());
   if (existing_item) {
@@ skipping 16 matching lines @@
 }
 
 void ExtensionAppModelBuilder::OnExtensionUninstalled(
     const Extension* extension) {
   if (service_) {
     DVLOG(2) << service_ << ": OnExtensionUninstalled: "
              << extension->id().substr(0, 8);
     service_->RemoveItem(extension->id());
     return;
   }
-  model_->item_list()->DeleteItem(extension->id());
+  model_->DeleteItem(extension->id());
 }
 
 void ExtensionAppModelBuilder::OnAppsReordered() {
   // Do nothing; App List order does not track extensions order.
 }
 
 void ExtensionAppModelBuilder::OnAppInstalledToAppList(
     const std::string& extension_id) {
   SetHighlightedApp(extension_id);
 }
@@ skipping 28 matching lines @@
     if (ShouldDisplayInAppLauncher(profile_, *app)) {
       apps->push_back(CreateAppItem((*app)->id(),
                                     "",
                                     gfx::ImageSkia(),
                                     (*app)->is_platform_app()));
     }
   }
 }
 
 void ExtensionAppModelBuilder::BuildModel() {
-  // Delete any extension apps.
-  model_->item_list()->DeleteItemsByType(ExtensionAppItem::kItemType);
-

[jennyz, 2014/01/28 18:02:48]

Is the model_ empty, or we just don't need to clear the old data before building
model?

[stevenjb, 2014/01/28 18:28:08]

This only gets called once now. We used to call this when we changed profiles,
but that changed and this got left. I didn't want to maintain DeleteItemsByType
when we don't actually need it. I'll add some DCHECKs and remove the if
(tracker_) code to make this more clear.

   if (tracker_)
     tracker_->RemoveObserver(this);
 
   tracker_ = controller_->GetInstallTrackerFor(profile_);
 
   PopulateApps();
   UpdateHighlight();
 
   // Start observing after model is built.
   if (tracker_)
@@ skipping 11 matching lines @@
 
   for (size_t i = 0; i < apps.size(); ++i)
     InsertApp(apps[i]);
 }
 
 void ExtensionAppModelBuilder::InsertApp(ExtensionAppItem* app) {
   if (service_) {
     service_->AddItem(app);
     return;
   }
-  model_->item_list()->AddItem(app);
+  model_->AddItem(app);
 }
 
 void ExtensionAppModelBuilder::SetHighlightedApp(
     const std::string& extension_id) {
   if (extension_id == highlight_app_id_)
     return;
   ExtensionAppItem* old_app = GetExtensionAppItem(highlight_app_id_);
   if (old_app)
     old_app->SetHighlighted(false);
   highlight_app_id_ = extension_id;
@@ skipping 50 matching lines @@
     app_list::AppListItem* item = item_list->item_at(idx + 1);
     if (item->GetItemType() == ExtensionAppItem::kItemType) {
       next = static_cast<ExtensionAppItem*>(item);
       break;
     }
   }
   // item->Move will call set_position, overriding the item's position.
   if (prev || next)
     static_cast<ExtensionAppItem*>(item)->Move(prev, next);
 }