Issue 14840018: Fix some build warnings in Nacl-specific code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14840018: Fix some build warnings in Nacl-specific code (Closed)

Created:
7 years, 7 months ago by eliben

Modified:
7 years, 7 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

More Reviews

Description

Fix some build warnings in Nacl-specific code BUG=None R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=1ab5bcc

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	lib/Analysis/NaCl/PNaClABITypeChecker.cpp	View		1 chunk	+0 lines, -1 line	2 comments	Download
	M	lib/Transforms/NaCl/PromoteIntegers.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Derek Schuff

lgtm thanks for fixing, that latter was a casualty of a late-breaking swap from assert ...

7 years, 7 months ago (2013-05-14 18:40:04 UTC) #2

eliben

https://codereview.chromium.org/14840018/diff/1/lib/Analysis/NaCl/PNaClABITypeChecker.cpp File lib/Analysis/NaCl/PNaClABITypeChecker.cpp (left): https://codereview.chromium.org/14840018/diff/1/lib/Analysis/NaCl/PNaClABITypeChecker.cpp#oldcode27 lib/Analysis/NaCl/PNaClABITypeChecker.cpp:27: unsigned Width; On 2013/05/14 18:40:04, Derek Schuff wrote: > ...

7 years, 7 months ago (2013-05-14 19:23:38 UTC) #3

eliben

7 years, 7 months ago (2013-05-14 19:23:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r1ab5bcc (presubmit successful).

Expand Messages | Collapse Messages