Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: Source/core/page/Page.h

Issue 14840015: Lose/restore WebGL contexts if multisampling blackist status changes at runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed to a more generic SettingsChangedObserver Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Page.h
diff --git a/Source/core/page/Page.h b/Source/core/page/Page.h
index d58734140d43ce0c6dcfb8c065bed6c6cd680450..5467ab41ce520a40f60380af26d837706a9d66da 100644
--- a/Source/core/page/Page.h
+++ b/Source/core/page/Page.h
@@ -259,6 +259,16 @@ public:
double timerAlignmentInterval() const;
+ class SettingsChangedObserver {
+ public:
+ virtual void settingsChanged(Settings*) = 0;
+ virtual ~SettingsChangedObserver() {}
abarth-chromium 2013/05/06 21:58:30 Shouldn't this destructor call removeSettingsChang
bajones 2013/05/06 22:44:14 Not a bad idea. I'll make sure that's in the next
+ };
+
+ void addSettingsChangedObserver(SettingsChangedObserver*);
+ void removeSettingsChangedObserver(SettingsChangedObserver*);
+ void settingsChanged() const;
+
private:
void initGroup();
@@ -339,6 +349,8 @@ private:
AlternativeTextClient* m_alternativeTextClient;
OwnPtr<PageConsole> m_console;
+
+ HashSet<SettingsChangedObserver*> m_settingsChangedObservers;
abarth-chromium 2013/05/06 21:58:30 More raw pointers... Can this be HashSet<OwnPtr<.
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698