Source/WebKit/chromium/public/WebSettings.h - Issue 14840015: Lose/restore WebGL contexts if multisampling blackist status changes at runtime.

Side by Side Diff: Source/WebKit/chromium/public/WebSettings.h

Issue 14840015: Lose/restore WebGL contexts if multisampling blackist status changes at runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed to a more generic SettingsChangedObserver Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 // these functions have a 1:1 mapping with the methods in WebCore/page/Settings. h.	45 // these functions have a 1:1 mapping with the methods in WebCore/page/Settings. h.

46 class WebSettings {	46 class WebSettings {

47 public:	47 public:

48 enum EditingBehavior {	48 enum EditingBehavior {

49 EditingBehaviorMac,	49 EditingBehaviorMac,

50 EditingBehaviorWin,	50 EditingBehaviorWin,

51 EditingBehaviorUnix,	51 EditingBehaviorUnix,

52 EditingBehaviorAndroid	52 EditingBehaviorAndroid

53 };	53 };

54	54

	55 virtual void settingsChanged() const = 0;
	abarth-chromium 2013/05/06 21:58:30 I'm surprised this is a public API. Is the embedd I'm surprised this is a public API. Is the embedder required to call this function any time it calls any setters on this object? If so, why not skip exposing it as an API and make the setters themselves call it? Ken Russell (switch to Gerrit) 2013/05/06 22:12:22 It's not possible to detect internally when would Show quoted text On 2013/05/06 21:58:30, abarth wrote: > I'm surprised this is a public API. Is the embedder required to call this > function any time it calls any setters on this object? If so, why not skip > exposing it as an API and make the setters themselves call it? It's not possible to detect internally when would be a good point to broadcast the settings changed notifications. Fortunately, there's only one point in the embedder that needs to call this method.
	56

55 virtual bool scrollAnimatorEnabled() const = 0;	57 virtual bool scrollAnimatorEnabled() const = 0;

56 virtual bool touchEditingEnabled() const = 0;	58 virtual bool touchEditingEnabled() const = 0;

57 virtual bool viewportEnabled() const = 0;	59 virtual bool viewportEnabled() const = 0;

58 virtual void setAccelerated2dCanvasEnabled(bool) = 0;	60 virtual void setAccelerated2dCanvasEnabled(bool) = 0;

59 virtual void setAcceleratedCompositingEnabled(bool) = 0;	61 virtual void setAcceleratedCompositingEnabled(bool) = 0;

60 virtual void setAcceleratedCompositingFor3DTransformsEnabled(bool) = 0;	62 virtual void setAcceleratedCompositingFor3DTransformsEnabled(bool) = 0;

61 virtual void setAcceleratedCompositingForAnimationEnabled(bool) = 0;	63 virtual void setAcceleratedCompositingForAnimationEnabled(bool) = 0;

62 virtual void setAcceleratedCompositingForCanvasEnabled(bool) = 0;	64 virtual void setAcceleratedCompositingForCanvasEnabled(bool) = 0;

63 virtual void setAcceleratedCompositingForFixedPositionEnabled(bool) = 0;	65 virtual void setAcceleratedCompositingForFixedPositionEnabled(bool) = 0;

64 virtual void setAcceleratedCompositingForOverflowScrollEnabled(bool) = 0;	66 virtual void setAcceleratedCompositingForOverflowScrollEnabled(bool) = 0;

(...skipping 113 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
178 void setApplyDefaultDeviceScaleFactorInCompositor(bool enabled) { }	180 void setApplyDefaultDeviceScaleFactorInCompositor(bool enabled) { }

179 void setFixedElementsLayoutRelativeToFrame(bool) { }	181 void setFixedElementsLayoutRelativeToFrame(bool) { }

180	182

181 protected:	183 protected:

182 ~WebSettings() { }	184 ~WebSettings() { }

183 };	185 };

184	186

185 } // namespace WebKit	187 } // namespace WebKit

186	188

187 #endif	189 #endif

OLD	NEW

« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebSettingsImpl.h » ('j') | Source/core/html/canvas/WebGLRenderingContext.h » ('J')