Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1483973002: MIPS: [turbofan] Enable Word32 safe shifts. (Closed)

Created:
5 years ago by dusan.milosavljevic
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Enable Word32 safe shifts. TEST= BUG= Committed: https://crrev.com/1d735a2d2e6db9a925cde1242de9abc5afc72afd Cr-Commit-Position: refs/heads/master@{#32465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dusan.milosavljevic
PTAL.
5 years ago (2015-11-30 14:51:29 UTC) #2
paul.l...
LGTM, thanks!
5 years ago (2015-12-01 01:53:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483973002/1
5 years ago (2015-12-01 12:32:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 14:03:11 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 14:04:03 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1d735a2d2e6db9a925cde1242de9abc5afc72afd
Cr-Commit-Position: refs/heads/master@{#32465}

Powered by Google App Engine
This is Rietveld 408576698