Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1483953004: CMake: generate SkUserConfig.h (Closed)

Created:
5 years ago by hal.canary
Modified:
5 years ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMake: generate SkUserConfig.hh CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/0cf5ecb67a2af5ec3ea20c5a189ff165ccb678c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M cmake/CMakeLists.txt View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483953004/1
5 years ago (2015-11-30 16:13:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 16:26:25 UTC) #5
hal.canary
Ptal
5 years ago (2015-11-30 17:50:54 UTC) #8
hal.canary
The followup CL will generate a skia.h for use by fiddle.
5 years ago (2015-11-30 18:11:22 UTC) #9
jcgregorio
lgtm
5 years ago (2015-11-30 18:28:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483953004/1
5 years ago (2015-11-30 18:28:48 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-30 18:29:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0cf5ecb67a2af5ec3ea20c5a189ff165ccb678c9

Powered by Google App Engine
This is Rietveld 408576698