Port cronet build rules to GN part 1

components/data_reduction_proxy/core/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+browser_sources = [
+  "data_reduction_proxy_bypass_protocol.cc",
+  "data_reduction_proxy_bypass_protocol.h",
+  "data_reduction_proxy_bypass_stats.cc",
+  "data_reduction_proxy_bypass_stats.h",
+  "data_reduction_proxy_compression_stats.cc",
+  "data_reduction_proxy_compression_stats.h",
+  "data_reduction_proxy_config.cc",
+  "data_reduction_proxy_config.h",
+  "data_reduction_proxy_config_retrieval_params.cc",
+  "data_reduction_proxy_config_retrieval_params.h",
+  "data_reduction_proxy_config_service_client.cc",
+  "data_reduction_proxy_config_service_client.h",
+  "data_reduction_proxy_configurator.cc",
+  "data_reduction_proxy_configurator.h",
+  "data_reduction_proxy_debug_ui_service.h",
+  "data_reduction_proxy_delegate.cc",
+  "data_reduction_proxy_delegate.h",
+  "data_reduction_proxy_experiments_stats.cc",
+  "data_reduction_proxy_experiments_stats.h",
+  "data_reduction_proxy_interceptor.cc",
+  "data_reduction_proxy_interceptor.h",
+  "data_reduction_proxy_io_data.cc",
+  "data_reduction_proxy_io_data.h",
+  "data_reduction_proxy_metrics.cc",
+  "data_reduction_proxy_metrics.h",
+  "data_reduction_proxy_mutable_config_values.cc",
+  "data_reduction_proxy_mutable_config_values.h",
+  "data_reduction_proxy_network_delegate.cc",
+  "data_reduction_proxy_network_delegate.h",
+  "data_reduction_proxy_prefs.cc",
+  "data_reduction_proxy_prefs.h",
+  "data_reduction_proxy_request_options.cc",
+  "data_reduction_proxy_request_options.h",
+  "data_reduction_proxy_service.cc",
+  "data_reduction_proxy_service.h",
+  "data_reduction_proxy_service_observer.h",
+  "data_reduction_proxy_settings.cc",
+  "data_reduction_proxy_settings.h",
+  "data_reduction_proxy_tamper_detection.cc",
+  "data_reduction_proxy_tamper_detection.h",
+  "data_store.cc",
+  "data_store.h",
+  "data_usage_store.cc",
+  "data_usage_store.h",
+  "db_data_owner.cc",
+  "db_data_owner.h",
+]
+
+if (is_android) {
+  source_set("browser_small") {
+    sources = browser_sources
+
+    deps = [
+      "//base",
+      "//components/data_reduction_proxy/core/common:common_small",
+      "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
+      "//components/pref_registry",
+      "//components/variations",
+      "//crypto",
+      "//net:net_small",
+      "//url:url_lib_use_icu_alternatives_on_android",
+    ]
+  }
+}
+
 source_set("browser") {
-  sources = [
-    "data_reduction_proxy_bypass_protocol.cc",
-    "data_reduction_proxy_bypass_protocol.h",
-    "data_reduction_proxy_bypass_stats.cc",
-    "data_reduction_proxy_bypass_stats.h",
-    "data_reduction_proxy_compression_stats.cc",
-    "data_reduction_proxy_compression_stats.h",
-    "data_reduction_proxy_config.cc",
-    "data_reduction_proxy_config.h",
-    "data_reduction_proxy_config_retrieval_params.cc",
-    "data_reduction_proxy_config_retrieval_params.h",
-    "data_reduction_proxy_config_service_client.cc",
-    "data_reduction_proxy_config_service_client.h",
-    "data_reduction_proxy_configurator.cc",
-    "data_reduction_proxy_configurator.h",
-    "data_reduction_proxy_debug_ui_service.h",
-    "data_reduction_proxy_delegate.cc",
-    "data_reduction_proxy_delegate.h",
-    "data_reduction_proxy_experiments_stats.cc",
-    "data_reduction_proxy_experiments_stats.h",
-    "data_reduction_proxy_interceptor.cc",
-    "data_reduction_proxy_interceptor.h",
-    "data_reduction_proxy_io_data.cc",
-    "data_reduction_proxy_io_data.h",
-    "data_reduction_proxy_metrics.cc",
-    "data_reduction_proxy_metrics.h",
-    "data_reduction_proxy_mutable_config_values.cc",
-    "data_reduction_proxy_mutable_config_values.h",
-    "data_reduction_proxy_network_delegate.cc",
-    "data_reduction_proxy_network_delegate.h",
-    "data_reduction_proxy_prefs.cc",
-    "data_reduction_proxy_prefs.h",
-    "data_reduction_proxy_request_options.cc",
-    "data_reduction_proxy_request_options.h",
-    "data_reduction_proxy_service.cc",
-    "data_reduction_proxy_service.h",
-    "data_reduction_proxy_service_observer.h",
-    "data_reduction_proxy_settings.cc",
-    "data_reduction_proxy_settings.h",
-    "data_reduction_proxy_tamper_detection.cc",
-    "data_reduction_proxy_tamper_detection.h",
-    "data_store.cc",
-    "data_store.h",
+  sources = browser_sources
+  sources += [
     "data_store_impl.cc",
     "data_store_impl.h",

[megjablon, 2015/12/08 20:03:31]

Why not add these two to browser_sources?

[pkotwicz, 2015/12/08 20:42:56]

Because browser_sources are sources for both "browser_small" and "browser" but
data_store_impl.* is not a source for "browser_small".

data_store_impl.cc was added to the GYP file in
https://codereview.chromium.org/1173343009 I am stupidly porting the GYP rules
to GN. I do not know why it is this way.

[bengr, 2015/12/10 00:19:45]

This is correct. Cronet and other consumers that use browser_small will not have
a persistent data store.

-    "data_usage_store.cc",
-    "data_usage_store.h",
-    "db_data_owner.cc",
-    "db_data_owner.h",
   ]
 
   deps = [
     "//base",
     "//base:prefs",
     "//components/data_reduction_proxy/core/common",
     "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
     "//components/pref_registry",
     "//components/variations",
     "//crypto",
@@ skipping 71 matching lines @@
     "//base:prefs_test_support",
     "//base/test:test_support",
     "//components/data_reduction_proxy/core/common:test_support",
     "//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
     "//components/variations",
     "//net:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
 }