src/core/SkGeometry.cpp - Issue 148383009: That's confusing. Make it clear we're working with 3 points == 9 scalars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkGeometry.cpp

Issue 148383009: That's confusing. Make it clear we're working with 3 points == 9 scalars. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkGeometry.cpp

diff --git a/src/core/SkGeometry.cpp b/src/core/SkGeometry.cpp

index 85ad39998328133f7cfa87dbbf620e9281c15fc6..b397241a1edac08641ff086bc4a0d19ac1a4113e 100644

--- a/src/core/SkGeometry.cpp

+++ b/src/core/SkGeometry.cpp

@@ -1338,7 +1338,7 @@ struct SkP3D {

// we just return the middle 3 points, since the first and last are dups of src

-static void p3d_interp(const SkScalar src[3], SkScalar dst[3], SkScalar t) {

+static void p3d_interp(const SkScalar src[9], SkScalar dst[9], SkScalar t) {

reed1 2014/01/28 13:20:36 Maybe they should be [7] ?

SkScalar ab = SkScalarInterp(src[0], src[3], t);

SkScalar bc = SkScalarInterp(src[3], src[6], t);

dst[0] = ab;

« no previous file with comments | « no previous file | no next file » | no next file with comments »