Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 148383009: That's confusing. Make it clear we're working with 3 points == 9 scalars. (Closed)

Created:
6 years, 10 months ago by mtklein_C
Modified:
6 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

That's confusing. Make it clear we're working with 3 points == 9 scalars. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13216

Patch Set 1 #

Total comments: 1

Patch Set 2 : ahh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/core/SkGeometry.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein_C
6 years, 10 months ago (2014-01-28 13:16:26 UTC) #1
reed1
https://codereview.chromium.org/148383009/diff/1/src/core/SkGeometry.cpp File src/core/SkGeometry.cpp (right): https://codereview.chromium.org/148383009/diff/1/src/core/SkGeometry.cpp#newcode1341 src/core/SkGeometry.cpp:1341: static void p3d_interp(const SkScalar src[9], SkScalar dst[9], SkScalar t) ...
6 years, 10 months ago (2014-01-28 13:20:35 UTC) #2
mtklein_C
On 2014/01/28 13:20:35, reed1 wrote: > https://codereview.chromium.org/148383009/diff/1/src/core/SkGeometry.cpp > File src/core/SkGeometry.cpp (right): > > https://codereview.chromium.org/148383009/diff/1/src/core/SkGeometry.cpp#newcode1341 > ...
6 years, 10 months ago (2014-01-28 13:37:31 UTC) #3
reed1
lgtm
6 years, 10 months ago (2014-01-28 14:07:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/148383009/20001
6 years, 10 months ago (2014-01-28 14:23:49 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 14:36:55 UTC) #6
Message was sent while issue was closed.
Change committed as 13216

Powered by Google App Engine
This is Rietveld 408576698