Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1483823004: EDK: Move {platform_handle,scoped_platform_handle}.* to //mojo/edk/platform. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Move {platform_handle,scoped_platform_handle}.* to //mojo/edk/platform. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2fcb5be6422055d40696d241aa06dc111d302cfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -322 lines) Patch
M mojo/edk/embedder/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 6 chunks +9 lines, -8 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/embedder/platform_channel_pair_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils.h View 3 chunks +12 lines, -11 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils.cc View 1 chunk +3 lines, -0 lines 0 comments Download
D mojo/edk/embedder/platform_handle.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/edk/embedder/platform_handle.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M mojo/edk/embedder/platform_handle_utils.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_handle_utils_posix.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_support.h View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/edk/embedder/scoped_platform_handle.h View 1 chunk +0 lines, -62 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/embedder/simple_platform_support.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/simple_platform_support.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/platform/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A + mojo/edk/platform/platform_handle.h View 2 chunks +5 lines, -5 lines 0 comments Download
A mojo/edk/platform/platform_handle.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A + mojo/edk/platform/scoped_platform_handle.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/channel.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/channel_manager.h View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/connection_manager.h View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/system/connection_manager_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/dispatcher.h View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/ipc_support.h View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/ipc_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/local_data_pipe_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/master_connection_manager.h View 6 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 4 chunks +9 lines, -7 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/raw_channel.h View 5 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/raw_channel_posix.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/slave_connection_manager.h View 5 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/transport_data.h View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper_unittest.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/test_utils.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/test/test_utils.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M shell/child_main.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M shell/child_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-11-30 19:45:55 UTC) #1
vardhan
lgtm
5 years ago (2015-11-30 20:15:23 UTC) #2
viettrungluu
5 years ago (2015-11-30 20:16:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2fcb5be6422055d40696d241aa06dc111d302cfb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698