Use const for const/final top-levels, types, symbols.

Use const for const/final top-levels, types, symbols.

BUG=
R=jmesserly@google.com, vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/87c73d0365a790828078f6379ce418abc28dbad9

[ochafik, 2015-11-29 14:24:53]

ochafik@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[ochafik, 2015-11-29 14:24:53]

Hey guys, what do you think of trading let for const where appropriate?

[vsm, 2015-11-30 16:34:23]

I don't have a strong opinion on this.  It's unfortunately a minor increase in
code size.  In Dart, folks seem to use var instead of final for similar reasons.

https://codereview.chromium.org/1483813002/diff/1/tool/sdk_expected_errors.txt
File tool/sdk_expected_errors.txt (right):

https://codereview.chromium.org/1483813002/diff/1/tool/sdk_expected_errors.tx...
tool/sdk_expected_errors.txt:11: severe: [AnalyzerMessage] The name 'T' is not a
type and cannot be used as a parameterized type
(dart:async/stream_controller.dart, line 657, col 45)
Hmm, these don't look related to your CL.  Perhaps from a new version of the
analyzer?

[Jennifer Messerly, 2015-11-30 16:38:52]

Well I'm biased but I think we should do it :). This will fix
https://github.com/dart-lang/dev_compiler/issues/156. Yay.

[Jennifer Messerly, 2015-11-30 16:39:52]

definitely worth checking what's up with sdk_expected_errors. Otherwise LGTM!

[vsm, 2015-11-30 16:42:12]

On 2015/11/30 16:39:52, John Messerly wrote:
> definitely worth checking what's up with sdk_expected_errors. Otherwise LGTM!

Fine with me.  LGTM.  The code size is really a small nit as it ought to get
optimized away whenever it really matters.

[ochafik, 2015-12-01 01:04:28]

On 2015/11/30 16:34:23, vsm wrote:
> I don't have a strong opinion on this.  It's unfortunately a minor increase in
> code size.  In Dart, folks seem to use var instead of final for similar
reasons.
> 
> https://codereview.chromium.org/1483813002/diff/1/tool/sdk_expected_errors.txt
> File tool/sdk_expected_errors.txt (right):
> 
>
https://codereview.chromium.org/1483813002/diff/1/tool/sdk_expected_errors.tx...
> tool/sdk_expected_errors.txt:11: severe: [AnalyzerMessage] The name 'T' is not
a
> type and cannot be used as a parameterized type
> (dart:async/stream_controller.dart, line 657, col 45)
> Hmm, these don't look related to your CL.  Perhaps from a new version of the
> analyzer?

Thanks for the regen!

[ochafik, 2015-12-01 01:06:17]

Description was changed from

==========
Use const for const/final top-levels, types, symbols.

BUG=
==========

to

==========
Use const for const/final top-levels, types, symbols.

BUG=
R=jmesserly@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/87c73d0365a790828078f6379ce4...
==========

[ochafik, 2015-12-01 01:06:18]

Committed patchset #2 (id:20001) manually as
87c73d0365a790828078f6379ce418abc28dbad9 (presubmit successful).