Issue 14838006: change setLength and Normalize to handle when mag2 overflows a float, but the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14838006: change setLength and Normalize to handle when mag2 overflows a float, but the (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

change setLength and Normalize to handle when mag2 overflows a float, but the actual lenght does not. R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=8988

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -29 lines)			Patch
	M	trunk/src/core/SkPoint.cpp	View		1 chunk	+58 lines, -14 lines	2 comments	Download
	M	trunk/tests/PointTest.cpp	View		2 chunks	+56 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

caryclark

lgtm https://codereview.chromium.org/14838006/diff/1/trunk/src/core/SkPoint.cpp File trunk/src/core/SkPoint.cpp (right): https://codereview.chromium.org/14838006/diff/1/trunk/src/core/SkPoint.cpp#newcode114 trunk/src/core/SkPoint.cpp:114: return false; return 0? https://codereview.chromium.org/14838006/diff/1/trunk/src/core/SkPoint.cpp#newcode143 trunk/src/core/SkPoint.cpp:143: } else ...

7 years, 7 months ago (2013-05-03 15:41:51 UTC) #2

reed1

7 years, 7 months ago (2013-05-03 15:59:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8988 (presubmit successful).

Expand Messages | Collapse Messages