Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Issue 1483733002: Remove support for NPObjects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
index e42c201323ebfc0538eeb349c9fa8f3059a23ef9..bfb61268e8a580060bf3e1f8c320481149fde3b5 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
@@ -28,8 +28,6 @@
#include "core/html/HTMLFrameOwnerElement.h"
#include <v8.h>
-struct NPObject;
-
namespace blink {
class HTMLImageLoader;
@@ -48,9 +46,10 @@ public:
DECLARE_VIRTUAL_TRACE();
void resetInstance();
+ // TODO(dcheng): Consider removing this, since HTMLEmbedElementLegacyCall
+ // and HTMLObjectElementLegacyCall usage is extremely low.
SharedPersistent<v8::Object>* pluginWrapper();
Widget* pluginWidget() const;
- NPObject* getNPObject();
void setPluginFocus(bool focused);
bool canProcessDrag() const;
const String& url() const { return m_url; }
@@ -135,7 +134,6 @@ private:
void setPersistedPluginWidget(Widget*);
mutable RefPtr<SharedPersistent<v8::Object>> m_pluginWrapper;
- NPObject* m_NPObject;
bool m_needsWidgetUpdate;
bool m_shouldPreferPlugInsForImages;

Powered by Google App Engine
This is Rietveld 408576698