Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.cc

Issue 14837004: Files.app: Fixed the problem that dialog opened by Ctrl+O cannot be expand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_dialog.cc
diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc
index d8b74ae02e5637027142a2f7bee71ef526967e7d..e830d61d3f098abbfc2eb11fc7badf7ca425aaca 100644
--- a/chrome/browser/ui/views/extensions/extension_dialog.cc
+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc
@@ -57,9 +57,14 @@ ExtensionDialog* ExtensionDialog::Show(
WebContents* web_contents,
int width,
int height,
+ int minWidth,
sky 2013/05/08 16:14:42 min_width, min_height How do we know we can trust
hirono 2013/05/09 02:23:16 Actually these arguments are added just for callin
sky 2013/05/09 15:51:57 I was assuming these values are coming from script
+ int minHeight,
const string16& title,
ExtensionDialogObserver* observer) {
extensions::ExtensionHost* host = CreateExtensionHost(url, profile);
+ // Preferred size must be set before views::Widget::CreateWindowWithParent
+ // is called because CreateWindowWithParent refers the result of CanResize().
+ host->view()->SetPreferredSize(gfx::Size(minWidth, minHeight));
if (!host)
return NULL;
host->SetAssociatedWebContents(web_contents);

Powered by Google App Engine
This is Rietveld 408576698