ozone: support gfx::BufferFormat::RGBX_8888 as a native pixmap format.

ui/ozone/platform/drm/gpu/gbm_buffer_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/gpu/gbm_buffer_base.h"
 
 #include <gbm.h>
 
 #include "base/logging.h"
 #include "ui/ozone/platform/drm/gpu/drm_device.h"
 
 namespace ui {
 
 GbmBufferBase::GbmBufferBase(const scoped_refptr<DrmDevice>& drm,
                              gbm_bo* bo,
                              bool scanout)
-    : drm_(drm), bo_(bo) {
+    : drm_(drm), bo_(bo), fb_pixel_format_(gbm_bo_get_format(bo)) {

[kalyank, 2015/12/11 04:57:41]

Unless its a scanout buffer and the buffer is registered, fb_pixel_format_should
just return 0. We should just leave this as before.

[dshwang, 2015/12/11 07:17:32]

Ok, agree.
To clarify, rename it to framebuffer_pixel_format_;

   if (scanout) {
-    fb_pixel_format_ = gbm_bo_get_format(bo);
-    if (fb_pixel_format_ == GBM_FORMAT_ARGB8888)
+    // Currently, drm supports 24 bitcolordepth for hardware overlay.
+    if (fb_pixel_format_ == GBM_FORMAT_ARGB8888 ||
+        fb_pixel_format_ == GBM_FORMAT_ABGR8888)

[kalyank, 2015/12/11 04:57:41]

ABGR, is this format going to be used ?

[dshwang, 2015/12/11 07:17:32]

ABGR is not used by chrome. However, ozone gbm supports ABGR scanout buffer, and
content_unittests covers if it works.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/ozone/platform/...

[kalyank, 2015/12/11 19:07:12]

Only BGRA and RGBA are advertised. In BGRA case, format has to be
GBM_FORMAT_BGRX8888.

[dshwang, 2015/12/13 05:34:43]

Got it. New CL supports both BGRX8888 and RGBX8888.

       fb_pixel_format_ = GBM_FORMAT_XRGB8888;
 
     // For now, we only support XRGB and UYVY format.
     DCHECK(fb_pixel_format_ == GBM_FORMAT_XRGB8888 ||
            fb_pixel_format_ == GBM_FORMAT_UYVY);
 
     uint32_t handles[4] = {0};
     handles[0] = gbm_bo_get_handle(bo).u32;
     uint32_t strides[4] = {0};
     strides[0] = gbm_bo_get_stride(bo);
@@ skipping 27 matching lines @@
 
 uint32_t GbmBufferBase::GetFramebufferPixelFormat() const {
   return fb_pixel_format_;
 }
 
 bool GbmBufferBase::RequiresGlFinish() const {
   return !drm_->is_primary_device();
 }
 
 }  // namespace ui