Issue 14836014: Fixed linkage for Is template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14836014: Fixed linkage for Is template. (Closed)

Created:
7 years, 7 months ago by Sven Panne

Modified:
7 years, 7 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed linkage for Is template. With static linkage, clang 3.3 is unhappy about unused functions template <> inline bool Is<JSFunction>(Object* obj) template <> inline bool Is<JSArray>(Object* obj) in any compilation unit apart from acessors.cc. R=mvstanton@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14657

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 7 months ago (2013-05-14 11:02:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14657 (presubmit successful).

Expand Messages | Collapse Messages