arc: Hide app list view on ARC app launch.

chrome/browser/ui/app_list/arc/arc_app_item.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/arc/arc_app_item.h"
 
+#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
+#include "chrome/browser/ui/app_list/app_list_service.h"
 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
+#include "chrome/browser/ui/host_desktop.h"
 #include "components/arc/arc_bridge_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/app_sorting.h"
 #include "extensions/browser/extension_prefs.h"
 #include "ui/app_list/app_list_constants.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/image/image_skia_operations.h"
 
 namespace {
 
+bool g_disable_controller_delegate = false;
+
 gfx::ImageSkia CreateDisabledIcon(const gfx::ImageSkia& icon) {
   const color_utils::HSL shift = {-1, 0, 0.6};
   return gfx::ImageSkiaOperations::CreateHSLShiftedImage(icon, shift);
 }
 
 extensions::AppSorting* GetAppSorting(content::BrowserContext* context) {
   return extensions::ExtensionPrefs::Get(context)->app_sorting();
 }
 
 }  // namespace
 
 // static
 const char ArcAppItem::kItemType[] = "ArcAppItem";
 
+// static
+void ArcAppItem::DisableContollerDelegateForTesting() {

[xiyuan, 2015/12/09 17:20:29]

I prefer to have something like

void OverrideAppListControllerDelegateForTesting(AppListControllerDelegate*
controller);

And GetController() returns the overridden instance if it is set.

[khmel1, 2015/12/10 05:19:04]

That is nice. Thanks for sharing best practices. I did it static as well.

+  g_disable_controller_delegate = true;
+}
+
 ArcAppItem::ArcAppItem(
     content::BrowserContext* context,
     const app_list::AppListSyncableService::SyncItem* sync_item,
     const std::string& id,
     const std::string& name,
     bool ready)
     : app_list::AppListItem(id),
       context_(context),
       ready_(ready) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ skipping 45 matching lines @@
 
   arc::ArcBridgeService* bridge_service = arc::ArcBridgeService::Get();
   if (!bridge_service ||
       bridge_service->state() != arc::ArcBridgeService::State::READY) {
     VLOG(2) << "Cannot launch app: " << app_info->package
             << ". Bridge service is not ready.";
     return;
   }
 
   bridge_service->LaunchApp(app_info->package, app_info->activity);
+
+  if (!g_disable_controller_delegate)
+    GetController()->DismissView();
 }
 
 void ArcAppItem::SetReady(bool ready) {
   if (ready_ == ready)
     return;
 
   ready_ = ready;
   UpdateIcon();
 }
 
 void ArcAppItem::SetName(const std::string& name) {
   SetNameAndShortName(name, name);
 }
 
 void ArcAppItem::UpdateIcon() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   gfx::ImageSkia icon = arc_app_icon_->image_skia();
   if (!ready_)
     icon = CreateDisabledIcon(icon);
 
   SetIcon(icon);
 }
 
 void ArcAppItem::OnIconUpdated() {
   UpdateIcon();
 }
+
+AppListControllerDelegate* ArcAppItem::GetController() {
+  return AppListService::Get(chrome::GetActiveDesktop())->

[khmel1, 2015/12/09 13:42:08]

I did similar to ExtensionsAppItem. However I don't think this is final code.
Functionality is duplicated but I am hesitating where to put it. Base class
belongs to ui/ package and I cannot move chrome/browser/ui dependencies there. 
WDYT?

[xiyuan, 2015/12/09 17:20:29]

We cannot put the AppListService etc into ui/ because it is a chrome concept and
does not belong there. We used to have a ChromeAppListItem (Removed in
https://codereview.chromium.org/25859005 by pushing down Activate() call into
ui/) that serves as the base class for app list items in chrome. We cannot do
similar unless we want to also move AppListControllerDelegate delegate etc into
ui/. So if we want to share this kind of code, we may need to resurrect it.

[khmel1, 2015/12/10 05:19:04]

Thanks for confirming that adding base class is acceptable way to handle it. I
did it in separate CL https://codereview.chromium.org/1507873006/

PS. This will also help me in my next steps for better ARC app integration into
app_list and shelf.

+      GetControllerDelegate();
+}