Issue 1483533003: Fix teardown of a couple of test suites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1483533003: Fix teardown of a couple of test suites

Created:
5 years ago by tommi (sloooow) - chröme

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix teardown of a couple of test suites. The MediaStreamManagerTest constructs and deletes the MediaStreamManager (MSM) on an IO thread, which differs from Chrome. This requires special care when tearing down the test. The IO thread in VideoCaptureControllerTest outlives the MSM which can cause pending messages on the IO thread for the MSM to be pending after the MSM has gone out of scope. This is also different from how things work in Chrome, so needs to be fixed. BUG=562378

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	content/browser/renderer_host/media/media_stream_manager_unittest.cc	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
	M	content/browser/renderer_host/media/video_capture_controller_unittest.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

New runloop

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1483533003: Fix teardown of a couple of test suites

Description

Patch Set 1 #

Patch Set 2 : Revert MSM test change. #

Patch Set 3 : New runloop #

Messages