chrome/browser/speech/speech_recognition_bubble_controller.cc - Issue 148343008: Speech Recognition API: Safeguarding against page closes during startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/speech_recognition_bubble_controller.cc

Issue 148343008: Speech Recognition API: Safeguarding against page closes during startup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanup Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/speech_recognition_bubble.h ('K') | « chrome/browser/speech/speech_recognition_bubble.cc ('k') | chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/speech_recognition_bubble_controller.cc

diff --git a/chrome/browser/speech/speech_recognition_bubble_controller.cc b/chrome/browser/speech/speech_recognition_bubble_controller.cc

index ff7aadd437097232e2e578808b9600debed4d8e0..ede3858ae69f7d96d6a6b0fcf49ea793df70c0ae 100644

--- a/chrome/browser/speech/speech_recognition_bubble_controller.cc

+++ b/chrome/browser/speech/speech_recognition_bubble_controller.cc

@@ -168,8 +168,7 @@ void SpeechRecognitionBubbleController::ProcessRequestInUiThread(

switch (request.type) {

case REQUEST_CREATE:

bubble_.reset(SpeechRecognitionBubble::Create(

- tab_util::GetWebContentsByID(request.render_process_id,

- request.render_view_id),

+ request.render_process_id, request.render_view_id,

this, request.element_rect));

if (!bubble_.get()) {