Speech Recognition API: Safeguarding against page closes during startup

chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/speech/speech_recognition_bubble_controller.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/browser_with_test_window_test.h"
 #include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/render_view_host.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/rect.h"
 
+
 using content::BrowserThread;
 using content::WebContents;
 
 namespace speech {
 
 // A mock bubble class which fakes a focus change or recognition cancel by the
 // user and closing of the info bubble.
 class MockSpeechRecognitionBubble : public SpeechRecognitionBubbleBase {
  public:
   enum BubbleType {
     BUBBLE_TEST_FOCUS_CHANGED,
     BUBBLE_TEST_CLICK_CANCEL,
     BUBBLE_TEST_CLICK_TRY_AGAIN,
   };
 
-  MockSpeechRecognitionBubble(WebContents* web_contents,
-                        Delegate* delegate,
-                        const gfx::Rect&)
-      : SpeechRecognitionBubbleBase(web_contents) {
+  MockSpeechRecognitionBubble(int render_process_id, int render_view_id,
+      Delegate* delegate, const gfx::Rect&)
+      : SpeechRecognitionBubbleBase(render_process_id, render_view_id) {
     VLOG(1) << "MockSpeechRecognitionBubble created";
     base::MessageLoop::current()->PostTask(
         FROM_HERE, base::Bind(&InvokeDelegate, delegate));
   }
 
   static void InvokeDelegate(Delegate* delegate) {
     VLOG(1) << "MockSpeechRecognitionBubble invoking delegate for type "
             << type_;
     switch (type_) {
       case BUBBLE_TEST_FOCUS_CHANGED:
@@ skipping 87 matching lines @@
       WebContents* web_contents,
       SpeechRecognitionBubble::Delegate* delegate,
       const gfx::Rect& element_rect) {
     EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::UI));
     // Set up to activate the bubble soon after it gets created, since we test
     // events sent by the bubble and those are handled only when the bubble is
     // active.
     base::MessageLoop::current()->PostTask(FROM_HERE,
                                            base::Bind(&ActivateBubble));
 
-    // The |web_contents| parameter would be NULL since the dummy session id
-    // passed to CreateBubble would not have matched any active tab. So get a
-    // real WebContents pointer from the test fixture and pass that, because
-    // the bubble controller registers for tab close notifications which need
-    // a valid WebContents.
-    web_contents =
-        test_fixture_->browser()->tab_strip_model()->GetActiveWebContents();
-    return new MockSpeechRecognitionBubble(web_contents, delegate,
-                                           element_rect);
+    return new MockSpeechRecognitionBubble(0, 0, delegate, element_rect);
   }
 
  protected:
   bool cancel_clicked_;
   bool try_again_clicked_;
   bool focus_changed_;
   scoped_refptr<SpeechRecognitionBubbleController> controller_;
 
   static const int kBubbleSessionId;
   static SpeechRecognitionBubbleControllerTest* test_fixture_;
@@ skipping 43 matching lines @@
 
   controller_->CreateBubble(kBubbleSessionId, 1, 1, gfx::Rect(1, 1));
   base::RunLoop().RunUntilIdle();
   EXPECT_FALSE(cancel_clicked_);
   EXPECT_TRUE(try_again_clicked_);
   EXPECT_FALSE(focus_changed_);
   controller_->CloseBubble();
 }
 
 }  // namespace speech