Speech Recognition API: Safeguarding against page closes during startup

chrome/browser/ui/gtk/speech_recognition_bubble_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/speech/speech_recognition_bubble.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 30 matching lines @@
 const GdkColor& kLabelTextColor = ui::kGdkBlack;
 
 // Implementation of SpeechRecognitionBubble for GTK. This shows a speech
 // recognition bubble on screen.
 class SpeechRecognitionBubbleGtk : public SpeechRecognitionBubbleBase,
                                    public BubbleDelegateGtk {
  public:
   SpeechRecognitionBubbleGtk(WebContents* web_contents,
                              Delegate* delegate,
                              const gfx::Rect& element_rect);
+  SpeechRecognitionBubbleGtk(int render_process_id, int render_view_id,
+                             Delegate* delegate,
+                             const gfx::Rect& element_rect);
   virtual ~SpeechRecognitionBubbleGtk();
 
  private:
   // SpeechRecognitionBubbleBase:
   virtual void Show() OVERRIDE;
   virtual void Hide() OVERRIDE;
   virtual void UpdateLayout() OVERRIDE;
   virtual void UpdateImage() OVERRIDE;
 
   // BubbleDelegateGtk:
@@ skipping 27 matching lines @@
       element_rect_(element_rect),
       did_invoke_close_(false),
       label_(NULL),
       cancel_button_(NULL),
       try_again_button_(NULL),
       icon_(NULL),
       icon_container_(NULL),
       mic_settings_(NULL) {
 }
 
+SpeechRecognitionBubbleGtk::SpeechRecognitionBubbleGtk(
+    int render_process_id, int render_view_id, Delegate* delegate,
+    const gfx::Rect& element_rect)
+    : SpeechRecognitionBubbleBase(render_process_id, render_process_id),
+      delegate_(delegate),
+      bubble_(NULL),
+      element_rect_(element_rect),
+      did_invoke_close_(false),
+      label_(NULL),
+      cancel_button_(NULL),
+      try_again_button_(NULL),
+      icon_(NULL),
+      icon_container_(NULL),
+      mic_settings_(NULL) {
+}
+
 SpeechRecognitionBubbleGtk::~SpeechRecognitionBubbleGtk() {
   // The |Close| call below invokes our |BubbleClosing| method. Since we were
   // destroyed by the caller we don't need to call them back, hence set this
   // flag here.
   did_invoke_close_ = true;
   Hide();
 }
 
 void SpeechRecognitionBubbleGtk::OnCancelClicked(GtkWidget* widget) {
   delegate_->InfoBubbleButtonClicked(BUTTON_CANCEL);
 }
 
 void SpeechRecognitionBubbleGtk::OnTryAgainClicked(GtkWidget* widget) {
   delegate_->InfoBubbleButtonClicked(BUTTON_TRY_AGAIN);
 }
 
 void SpeechRecognitionBubbleGtk::OnMicSettingsClicked(GtkWidget* widget) {
   content::SpeechRecognitionManager::GetInstance()->ShowAudioInputSettings();
   Hide();
 }
 
 void SpeechRecognitionBubbleGtk::Show() {
-  if (bubble_)
+  if (bubble_ || !GetWebContents())
     return;  // Nothing further to do since the bubble is already visible.
 
   // We use a vbox to arrange the controls (label, image, button bar) vertically
   // and the button bar is a hbox holding the 2 buttons (try again and cancel).
   // To get horizontal space around them we place this vbox with padding in a
   // GtkAlignment below.
   GtkWidget* vbox = gtk_vbox_new(FALSE, 0);
 
   // The icon with a some padding on the left and right.
   icon_container_ = gtk_alignment_new(0, 0, 0, 0);
@@ skipping 69 matching lines @@
                             content,
                             BubbleGtk::ANCHOR_TOP_LEFT,
                             BubbleGtk::POPUP_WINDOW | BubbleGtk::GRAB_INPUT,
                             theme_provider,
                             this);
 
   UpdateLayout();
 }
 
 void SpeechRecognitionBubbleGtk::Hide() {
-  if (bubble_)
+  if (bubble_ && GetWebContents())
     bubble_->Close();
 }
 
 void SpeechRecognitionBubbleGtk::UpdateLayout() {
-  if (!bubble_)
+  if (!bubble_ || !GetWebContents())
     return;
 
   if (display_mode() == DISPLAY_MODE_MESSAGE) {
     // Message text and the Try Again + Cancel buttons are visible, hide the
     // icon.
     gtk_label_set_text(GTK_LABEL(label_),
                        base::UTF16ToUTF8(message_text()).c_str());
     gtk_widget_show(label_);
     gtk_widget_show(try_again_button_);
     if (mic_settings_)
@@ skipping 65 matching lines @@
 }
 
 }  // namespace
 
 SpeechRecognitionBubble* SpeechRecognitionBubble::CreateNativeBubble(
     WebContents* web_contents,
     Delegate* delegate,
     const gfx::Rect& element_rect) {
   return new SpeechRecognitionBubbleGtk(web_contents, delegate, element_rect);
 }
+
+SpeechRecognitionBubble* SpeechRecognitionBubble::CreateNativeBubble(
+    int render_process_id, int render_view_id,
+    SpeechRecognitionBubble::Delegate* delegate,
+    const gfx::Rect& element_rect) {
+  return new SpeechRecognitionBubbleGtk(render_process_id, render_view_id,
+      delegate, element_rect);
+}
+