build/common.gypi - Issue 14834011: Android: use grit target platform instead of define.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 14834011: Android: use grit target platform instead of define. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add missed pp_ifdef(android) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index d09d8ab5dd8ad14336901c314abc4d9446000e06..80cba3ea3ab610fcdc7ed4c569ef979a754cc9ea 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1493,7 +1493,7 @@

}],

['OS=="android"', {

- 'grit_defines': ['-D', 'android',

+ 'grit_defines': ['-t', 'android',

'-E', 'ANDROID_JAVA_TAGGED_ONLY=true'],

}],

['OS=="mac"', {

« no previous file with comments | « no previous file | chrome/app/bookmarks_strings.grdp » ('j') | no next file with comments »