Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1483343004: tools/gn: remove three unused functions from string_utils.h (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: remove three unused functions from string_utils.h git grep shows these functions have no callers anymore. BUG=None TEST=gn gen + gn_unittests R=scottmg@chromium.org Committed: https://crrev.com/0814cd9120dc3b96cc99a430188f4e3c0d2e2201 Cr-Commit-Position: refs/heads/master@{#362516}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M tools/gn/string_utils.h View 1 chunk +0 lines, -18 lines 1 comment Download
M tools/gn/string_utils.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
PTAL. https://codereview.chromium.org/1483343004/diff/1/tools/gn/string_utils.h File tools/gn/string_utils.h (left): https://codereview.chromium.org/1483343004/diff/1/tools/gn/string_utils.h#oldcode42 tools/gn/string_utils.h:42: std::string RemovePrefix(const std::string& str, const std::string& prefix); I ...
5 years ago (2015-12-01 19:53:44 UTC) #1
scottmg
lgtm
5 years ago (2015-12-01 20:31:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483343004/1
5 years ago (2015-12-01 21:35:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 22:01:12 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 22:02:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0814cd9120dc3b96cc99a430188f4e3c0d2e2201
Cr-Commit-Position: refs/heads/master@{#362516}

Powered by Google App Engine
This is Rietveld 408576698