Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148333009: Move webkit/child/webkitplatformsupport_child_impl to content/ (Closed)

Created:
6 years, 10 months ago by pilgrim_google
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jamesr
Visibility:
Public.

Description

Move webkit/child/webkitplatformsupport_child_impl to content/ BUG=338338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247904

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : add export macros for Mac and Android #

Total comments: 8

Patch Set 6 : fixes for Windows and Android builds, plus fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -259 lines) Patch
A + content/child/webkitplatformsupport_child_impl.h View 1 2 3 4 5 3 chunks +13 lines, -10 lines 0 comments Download
A + content/child/webkitplatformsupport_child_impl.cc View 1 2 3 4 5 8 chunks +18 lines, -14 lines 0 comments Download
M content/child/webkitplatformsupport_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/test_webkit_platform_support.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/child/fling_curve_configuration.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M webkit/child/webfallbackthemeengine_impl.h View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M webkit/child/webkit_child.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/child/webkitplatformsupport_child_impl.h View 1 chunk +0 lines, -72 lines 0 comments Download
D webkit/child/webkitplatformsupport_child_impl.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M webkit/child/webthemeengine_impl_android.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M webkit/child/webthemeengine_impl_default.h View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M webkit/child/webthemeengine_impl_mac.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M webkit/child/webthemeengine_impl_win.h View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M webkit/child/worker_task_runner.h View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pilgrim_google
6 years, 10 months ago (2014-01-28 19:58:22 UTC) #1
pilgrim_google
6 years, 10 months ago (2014-01-28 19:59:25 UTC) #2
darin (slow to review)
LGTM w/ some style nits fixed. https://codereview.chromium.org/148333009/diff/70001/content/child/webkitplatformsupport_child_impl.cc File content/child/webkitplatformsupport_child_impl.cc (right): https://codereview.chromium.org/148333009/diff/70001/content/child/webkitplatformsupport_child_impl.cc#newcode91 content/child/webkitplatformsupport_child_impl.cc:91: webkit_glue::WebThreadImplForMessageLoop* thread = ...
6 years, 10 months ago (2014-01-29 17:58:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/148333009/90001
6 years, 10 months ago (2014-01-29 19:57:08 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 08:51:42 UTC) #5
Message was sent while issue was closed. 
Change committed as 247904

Powered by Google App Engine
This is Rietveld 408576698