Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: src/stub-cache.cc

Issue 148333003: crankshaft support for api method calls (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/stub-cache.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/stub-cache.cc
diff --git a/src/stub-cache.cc b/src/stub-cache.cc
index f715573556257b93a5b268a6b357d3e1c3ce5109..b4e3bdf61af73d9adfff32825a42e7d2613f0fc5 100644
--- a/src/stub-cache.cc
+++ b/src/stub-cache.cc
@@ -1288,15 +1288,6 @@ Handle<Code> CallStubCompiler::CompileCallConstant(
Handle<Name> name,
CheckType check,
Handle<JSFunction> function) {
- if (HasCustomCallGenerator(function)) {
- Handle<Code> code = CompileCustomCall(object, holder,
- Handle<Cell>::null(),
- function, Handle<String>::cast(name),
- Code::FAST);
- // A null handle means bail out to the regular compiler code below.
- if (!code.is_null()) return code;
- }
-
Label miss;
HandlerFrontendHeader(object, holder, name, check, &miss);
GenerateJumpFunction(object, function);
@@ -1877,31 +1868,6 @@ CallStubCompiler::CallStubCompiler(Isolate* isolate,
}
-bool CallStubCompiler::HasCustomCallGenerator(Handle<JSFunction> function) {
- CallOptimization optimization(function);
- return optimization.is_simple_api_call();
-}
-
-
-Handle<Code> CallStubCompiler::CompileCustomCall(
- Handle<Object> object,
- Handle<JSObject> holder,
- Handle<Cell> cell,
- Handle<JSFunction> function,
- Handle<String> fname,
- Code::StubType type) {
- ASSERT(HasCustomCallGenerator(function));
- CallOptimization optimization(function);
- ASSERT(optimization.is_simple_api_call());
- return CompileFastApiCall(optimization,
- object,
- holder,
- cell,
- function,
- fname);
-}
-
-
Handle<Code> CallStubCompiler::GetCode(Code::StubType type,
Handle<Name> name) {
int argc = arguments_.immediate();
@@ -1937,44 +1903,32 @@ CallOptimization::CallOptimization(Handle<JSFunction> function) {
}
-Handle<Map> CallOptimization::LookupHolderOfExpectedType(
- Handle<JSObject> receiver,
- Handle<JSObject> object,
- Handle<JSObject> holder,
+Handle<JSObject> CallOptimization::LookupHolderOfExpectedType(
+ Handle<Map> object_map,
HolderLookup* holder_lookup) const {
ASSERT(is_simple_api_call());
ASSERT_EQ(kHolderNotFound, *holder_lookup);
- *holder_lookup = kHolderIsReceiver;
- Handle<Map> map_to_holder;
- if (expected_receiver_type_.is_null()) {
- // no expected type, load from receiver.
- return map_to_holder;
+ if (!object_map->IsJSObjectMap()) {
+ *holder_lookup = kHolderNotFound;
+ return Handle<JSObject>::null();
}
- // walk down the prototype chain to the object
- while (!receiver.is_identical_to(object)) {
- *holder_lookup = kHolderIsPrototypeOfMap;
- map_to_holder = Handle<Map>(receiver->map());
- receiver = Handle<JSObject>(JSObject::cast(map_to_holder->prototype()));
+ if (expected_receiver_type_.is_null() ||
+ expected_receiver_type_->IsTemplateFor(*object_map)) {
+ *holder_lookup = kHolderIsReceiver;
+ return Handle<JSObject>::null();
}
- // start looking for the holder
- while (!object.is_identical_to(holder)) {
- Handle<Map> object_map(object->map());
+ while (true) {
+ if (!object_map->prototype()->IsJSObject()) break;
+ Handle<JSObject> prototype(JSObject::cast(object_map->prototype()));
+ if (!prototype->map()->is_hidden_prototype()) break;
+ object_map = handle(prototype->map());
if (expected_receiver_type_->IsTemplateFor(*object_map)) {
- return map_to_holder;
- }
- if (!object_map->is_hidden_prototype()) {
- *holder_lookup = kHolderNotFound;
- return Handle<Map>::null();
+ *holder_lookup = kHolderFound;
+ return prototype;
}
- *holder_lookup = kHolderIsPrototypeOfMap;
- map_to_holder = object_map;
- object = Handle<JSObject>(JSObject::cast(object_map->prototype()));
- }
- if (expected_receiver_type_->IsTemplateFor(holder->map())) {
- return map_to_holder;
}
*holder_lookup = kHolderNotFound;
- return Handle<Map>::null();
+ return Handle<JSObject>::null();
}
« no previous file with comments | « src/stub-cache.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698