Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148333003: crankshaft support for api method calls (Closed)

Created:
6 years, 11 months ago by dcarney
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

crankshaft support for api method calls R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18946

Patch Set 1 : all arches #

Patch Set 2 : whoops #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : more #

Patch Set 5 : more deletion #

Patch Set 6 : works #

Patch Set 7 : refactor #

Patch Set 8 : fix #

Patch Set 9 : additional check #

Patch Set 10 : rebase #

Patch Set 11 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -528 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +26 lines, -11 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M src/arm/simulator-arm.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +5 lines, -136 lines 0 comments Download
M src/hydrogen.h View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 5 chunks +124 lines, -31 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 7 8 9 1 chunk +20 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 4 5 6 7 8 9 4 chunks +2 lines, -125 lines 0 comments Download
M src/isolate.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.h View 1 2 3 4 5 6 2 chunks +4 lines, -28 lines 0 comments Download
M src/stub-cache.cc View 1 2 3 4 5 6 7 8 3 chunks +17 lines, -63 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 8 9 1 chunk +20 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 4 5 6 7 8 9 4 chunks +2 lines, -126 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 1 chunk +129 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
ptal
6 years, 10 months ago (2014-01-29 12:04:35 UTC) #1
Toon Verwaest
Looks good. Please make the explicit what the api-holder-check does though. https://codereview.chromium.org/148333003/diff/110001/src/stub-cache.cc File src/stub-cache.cc (right): ...
6 years, 10 months ago (2014-01-29 13:22:39 UTC) #2
Toon Verwaest
A lot better this way. LGTM
6 years, 10 months ago (2014-01-29 15:02:14 UTC) #3
dcarney
6 years, 10 months ago (2014-01-30 13:18:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #11 manually as r18946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698