Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 148323011: Redo r19140 with better efficiency. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Redo r19140 with better efficiency. Still relevant parts of the original commit message: Unify paren handling in Parser and PreParser. It is only needed in (Pre)Parser::ParseExpressionOrLabelledStatement for not recognizing parenthesized identifiers as labels and in (Pre)Parser::ParseSourceElements for not recognizing a parenthesized string as directive prologue. Parser Expressions don't keep track of whether they're parenthesized, so PreParser Expressions shouldn't either. BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -51 lines) Patch
M src/preparser.h View 5 chunks +5 lines, -42 lines 0 comments Download
M src/preparser.cc View 3 chunks +15 lines, -9 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
lgtm
6 years, 10 months ago (2014-02-06 13:11:11 UTC) #1
marja
6 years, 10 months ago (2014-02-06 13:12:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19153 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698