Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 148323010: A64: Replace EmitBranch(instr, al) with unconditional branch. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Replace EmitBranch(instr, al) with unconditional branch. EmitBranch asserts that the condition is not 'al'. TEST=mjsunit/compiler/short-circuit R=baptiste.afsa@arm.com Committed: https://code.google.com/p/v8/source/detail?r=19160

Patch Set 1 #

Total comments: 2

Patch Set 2 : EmitGoto #

Total comments: 1

Patch Set 3 : Real fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/a64/lithium-codegen-a64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
ulan
PTAL
6 years, 10 months ago (2014-02-06 12:23:56 UTC) #1
baptiste.afsa1
https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64.cc#newcode1740 src/a64/lithium-codegen-a64.cc:1740: __ B(true_label); Maybe you should use EmitGoto so we ...
6 years, 10 months ago (2014-02-06 13:00:06 UTC) #2
ulan
Thanks, I uploaded new patch set. https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64.cc#newcode1740 src/a64/lithium-codegen-a64.cc:1740: __ B(true_label); On ...
6 years, 10 months ago (2014-02-06 13:17:40 UTC) #3
baptiste.afsa1
https://codereview.chromium.org/148323010/diff/60001/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/148323010/diff/60001/src/a64/lithium-codegen-a64.cc#newcode1740 src/a64/lithium-codegen-a64.cc:1740: __ EmitGoto(true_label); I don't think that it works. I ...
6 years, 10 months ago (2014-02-06 13:32:33 UTC) #4
ulan
Thanks, uploaded a fix that compiles now =)
6 years, 10 months ago (2014-02-06 14:28:30 UTC) #5
baptiste.afsa1
lgtm
6 years, 10 months ago (2014-02-06 14:31:53 UTC) #6
ulan
6 years, 10 months ago (2014-02-06 14:41:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r19160 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698