A64: Replace EmitBranch(instr, al) with unconditional branch.

A64: Replace EmitBranch(instr, al) with unconditional branch.

EmitBranch asserts that the condition is not 'al'.

TEST=mjsunit/compiler/short-circuit
R=baptiste.afsa@arm.com

Committed: https://code.google.com/p/v8/source/detail?r=19160

[ulan, 2014-02-06 12:23:56]

PTAL

[baptiste.afsa1, 2014-02-06 13:00:06]

https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:1740: __ B(true_label);
Maybe you should use EmitGoto so we don't emit the branch instruction if we can
fall-through to the next block.

[ulan, 2014-02-06 13:17:40]

Thanks, I uploaded new patch set.

https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/148323010/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:1740: __ B(true_label);
On 2014/02/06 13:00:06, baptiste.afsa1 wrote:
> Maybe you should use EmitGoto so we don't emit the branch instruction if we
can
> fall-through to the next block.

Done.

[baptiste.afsa1, 2014-02-06 13:32:33]

https://codereview.chromium.org/148323010/diff/60001/src/a64/lithium-codegen-...
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/148323010/diff/60001/src/a64/lithium-codegen-...
src/a64/lithium-codegen-a64.cc:1740: __ EmitGoto(true_label);
I don't think that it works. I don't think we have an EmitGoto in the
MacroAssembler but we have an helper in LCodeGen.

I think that something like that should be good here:
  EmitGoto(instr->TrueDestination(chunk()));

[ulan, 2014-02-06 14:28:30]

Thanks, uploaded a fix that compiles now =)

[baptiste.afsa1, 2014-02-06 14:31:53]

lgtm

[ulan, 2014-02-06 14:41:06]

Committed patchset #3 manually as r19160 (tree was closed).