Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: LayoutTests/fast/dom/htmlcollection-enumerated-properties.html

Issue 148323008: Update HTMLCollection's named property getter to behave according to spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take feedback into consideation Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/htmlcollection-enumerated-properties.html
diff --git a/LayoutTests/fast/dom/htmlcollection-enumerated-properties.html b/LayoutTests/fast/dom/htmlcollection-enumerated-properties.html
new file mode 100644
index 0000000000000000000000000000000000000000..fa3c6aefb57399ecfb1ef8e52a5ea8b5188615a0
--- /dev/null
+++ b/LayoutTests/fast/dom/htmlcollection-enumerated-properties.html
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test.js"></script>
+<a id="id1" name="name1"></a>
+<a id="id2" name="name1"></a>
+<a id="id3"></a>
+<a id="id4" name="name4"></a>
+<a name="name5"></a>
+<a id="id4" name="name6"></a>
+
+<script>
+description("This tests verifies the enumerated properties on HTMLCollection and their order.");
+
+var testLink = document.getElementById("testLink");
+var htmlCollection = document.getElementsByTagName("a");
+shouldBe("htmlCollection.__proto__", "HTMLCollection.prototype");
+shouldBe("htmlCollection.length", "6");
+
+// As per http://dom.spec.whatwg.org/#htmlcollection:
+// - The object's supported property indices are the numbers in the range zero to one less than the
+// number of nodes represented by the collection. If there are no such elements, then there are no
+// supported property indices.
+// - The supported property names are the values from the list returned by these steps:
+// 1. Let result be an empty list.
+// 2. For each element represented by the collection, in tree order, run these substeps:
+// 1. If element is in the HTML namespace and has a name attribute whose value is neither the empty string
+// nor is in result, append element's name attribute value to result.
+// 2. If element has an ID which is neither the empty string nor is in result, append element's ID to result.
+// 3. Return result.
+var expectedEnumeratedProperties = ["0", "1" , "2", "3", "4", "5", "length", "name1", "id1", "id2", "id3", "name4", "id4", "name5", "name6", "item", "namedItem"];
+
+var enumeratedProperties = [];
+for (var property in htmlCollection) {
+ enumeratedProperties[enumeratedProperties.length] = property;
+}
+shouldBe("enumeratedProperties", "expectedEnumeratedProperties");
+</script>
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698