Update HTMLCollection's named property getter to behave according to spec

Source/core/html/HTMLCollection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
@@ skipping 10 matching lines @@
 
 #include "HTMLNames.h"
 #include "core/dom/ClassCollection.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/NodeList.h"
 #include "core/dom/NodeRareData.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/html/HTMLElement.h"
 #include "core/html/HTMLObjectElement.h"
 #include "core/html/HTMLOptionElement.h"
+#include "wtf/HashSet.h"
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 static bool shouldOnlyIncludeDirectChildren(CollectionType type)
 {
     switch (type) {
     case ClassCollectionType:
     case TagCollectionType:
@@ skipping 435 matching lines @@
     if (idResults && !idResults->isEmpty())
         return idResults->first();
 
     Vector<Element*>* nameResults = nameCache(name);
     if (nameResults && !nameResults->isEmpty())
         return nameResults->first();
 
     return 0;
 }
 
+bool HTMLCollection::namedPropertyQuery(const AtomicString& name, ExceptionState&)
+{
+    return namedItem(name);
+}
+
+void HTMLCollection::supportedPropertyNames(Vector<String>& names)
+{
+    // The supported property names are the values from the list returned by these steps:

[haraken, 2014/02/06 02:47:41]

You can add a spec link:
http://dom.spec.whatwg.org/#htmlcollection

[Inactive, 2014/02/06 02:55:39]

Will do.

[Inactive, 2014/02/06 03:03:29]

Done.

+    // 1. Let result be an empty list.
+    // 2. For each element represented by the collection, in tree order, run these substeps:
+    //   1. If element is in the HTML namespace and has a name attribute whose value is neither the empty string
+    //      nor is in result, append element's name attribute value to result.
+    //   2. If element has an ID which is neither the empty string nor is in result, append element's ID to result.
+    // 3. Return result.
+    HashSet<AtomicString> existingNames;
+    ContainerNode& root = rootNode();
+    for (Element* element = traverseToFirstElement(root); element; element = traverseNextElement(*element, root)) {
+        if (element->isHTMLElement()) {
+            const AtomicString& nameAttribute = element->getNameAttribute();
+            if (!nameAttribute.isEmpty() && (type() != DocAll || nameShouldBeVisibleInDocumentAll(toHTMLElement(*element)))) {

[haraken, 2014/02/06 02:47:41]

I'm just curious: Where is this condition speced?

[Inactive, 2014/02/06 02:55:39]

Right, this is spec'd at:
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interf...

The same condition is used below in HTMLCollection::updateNameCache().

This does not have an impact yet though, HTMLAllCollection.idl needs to be
updated so that this method gets called for HTMLAllCollection as well.

[Inactive, 2014/02/06 03:01:24]

Oops, the HTMLAllCollection spec says "with the id of an element preceding its
name if it contributes both" so this won't be sufficient. (HTMLCollection shows
the name before the id)

I will keep this change out of this change for now. For HTMLAllCollection, I
will likely override supportedPropertyNames() instead then.

[Inactive, 2014/02/06 03:03:29]

Done.

+                HashSet<AtomicString>::AddResult addResult = existingNames.add(nameAttribute);
+                if (addResult.isNewEntry)
+                    names.append(nameAttribute);
+            }
+        }
+        const AtomicString& idAttribute = element->getIdAttribute();
+        if (!idAttribute.isEmpty()) {
+            HashSet<AtomicString>::AddResult addResult = existingNames.add(idAttribute);
+            if (addResult.isNewEntry)
+                names.append(idAttribute);
+        }
+    }
+}
+
+void HTMLCollection::namedPropertyEnumerator(Vector<String>& names, ExceptionState&)
+{
+    return supportedPropertyNames(names);
+}
+
 void HTMLCollection::updateNameCache() const
 {
     if (hasNameCache())
         return;
 
     ContainerNode& root = rootNode();
     for (Element* element = traverseToFirstElement(root); element; element = traverseNextElement(*element, root)) {
         const AtomicString& idAttrVal = element->getIdAttribute();
         if (!idAttrVal.isEmpty())
             appendIdCache(idAttrVal, element);
@@ skipping 27 matching lines @@
 
 void HTMLCollection::append(NodeCacheMap& map, const AtomicString& key, Element* element)
 {
     OwnPtr<Vector<Element*> >& vector = map.add(key.impl(), nullptr).iterator->value;
     if (!vector)
         vector = adoptPtr(new Vector<Element*>);
     vector->append(element);
 }
 
 } // namespace WebCore