Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: gm/convexpolyeffect.cpp

Issue 1483103003: Make onPrepareDraws const (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/convexpolyeffect.cpp
diff --git a/gm/convexpolyeffect.cpp b/gm/convexpolyeffect.cpp
index f040b90ed28a56cbb110948a600a0beae9304d51..caed554b8b8eb1afe4668b1f53f9d6e4fb4817d4 100644
--- a/gm/convexpolyeffect.cpp
+++ b/gm/convexpolyeffect.cpp
@@ -45,6 +45,7 @@ private:
ConvexPolyTestBatch(const GrGeometryProcessor* gp, const Geometry& geo)
: INHERITED(ClassID(), gp, geo.fBounds)
, fGeometry(geo) {
+ fGeometry.fBounds.outset(5.f, 5.f);
}
Geometry* geoData(int index) override {
@@ -57,7 +58,7 @@ private:
return &fGeometry;
}
- void generateGeometry(Target* target) override {
+ void generateGeometry(Target* target) const override {
size_t vertexStride = this->geometryProcessor()->getVertexStride();
SkASSERT(vertexStride == sizeof(SkPoint));
QuadHelper helper;
@@ -68,7 +69,6 @@ private:
robertphillips 2015/11/30 19:52:40 Move the comment too ?
// Make sure any artifacts around the exterior of path are visible by using overly
// conservative bounding geometry.
- fGeometry.fBounds.outset(5.f, 5.f);
fGeometry.fBounds.toQuad(verts);
helper.recordDraw(target);

Powered by Google App Engine
This is Rietveld 408576698