Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1483103003: Make onPrepareDraws const (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : tweaks #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -124 lines) Patch
M gm/beziereffects.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrPathUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 2 5 chunks +13 lines, -6 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 2 10 chunks +15 lines, -17 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrNinePatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/batches/GrTInstanceBatch.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 11 chunks +52 lines, -42 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
joshualitt
ptal, might want to take a closer look at the changes, they are really minor.
5 years ago (2015-11-30 19:35:54 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1483103003/diff/1/gm/convexpolyeffect.cpp File gm/convexpolyeffect.cpp (right): https://codereview.chromium.org/1483103003/diff/1/gm/convexpolyeffect.cpp#newcode69 gm/convexpolyeffect.cpp:69: Move the comment too ? https://codereview.chromium.org/1483103003/diff/1/src/gpu/batches/GrAAConvexPathRenderer.cpp File src/gpu/batches/GrAAConvexPathRenderer.cpp ...
5 years ago (2015-11-30 19:52:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483103003/40001
5 years ago (2015-11-30 20:17:00 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-30 20:30:21 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/144c3c8b7ff3ebc389b41211f3388fb24a7ff0c2

Powered by Google App Engine
This is Rietveld 408576698