util/win/exception_handler_server.cc - Issue 1483073004: Replace use of .Pass() with crashpad::move().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/win/exception_handler_server.cc

Issue 1483073004: Replace use of .Pass() with crashpad::move(). (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: pass: more80cols-and-fix-move Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/win/exception_handler_server.cc

diff --git a/util/win/exception_handler_server.cc b/util/win/exception_handler_server.cc

index 05087f1e604ced7aa58e965fb44dc600969e5350..023abf114f306808948fa14c76fba8f964cd18a9 100644

--- a/util/win/exception_handler_server.cc

+++ b/util/win/exception_handler_server.cc

@@ -26,6 +26,7 @@

#include "snapshot/crashpad_info_client_options.h"

#include "snapshot/win/process_snapshot_win.h"

#include "util/file/file_writer.h"

+#include "util/misc/move.h"

#include "util/misc/random_string.h"

#include "util/misc/tri_state.h"

#include "util/misc/uuid.h"

@@ -179,7 +180,7 @@ class ClientData {

CreateEvent(nullptr, false /* auto reset */, false, nullptr)),

non_crash_dump_completed_event_(

CreateEvent(nullptr, false /* auto reset */, false, nullptr)),

- process_(process.Pass()),

+ process_(crashpad::move(process)),

crash_exception_information_address_(

crash_exception_information_address),

non_crash_exception_information_address_(