handler/crash_report_upload_thread.cc - Issue 1483073004: Replace use of .Pass() with crashpad::move().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: handler/crash_report_upload_thread.cc

Issue 1483073004: Replace use of .Pass() with crashpad::move(). (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: pass: . Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: handler/crash_report_upload_thread.cc

diff --git a/handler/crash_report_upload_thread.cc b/handler/crash_report_upload_thread.cc

index b88f3e1bdb7b12c3fbcb6b6d33980f00ff8a0239..c5fdfaad2e6607cb6c33f7e219331ad3deedbe92 100644

--- a/handler/crash_report_upload_thread.cc

+++ b/handler/crash_report_upload_thread.cc

@@ -28,6 +28,7 @@

#include "snapshot/minidump/process_snapshot_minidump.h"

#include "snapshot/module_snapshot.h"

#include "util/file/file_reader.h"

+#include "util/stdlib/move.h"

#include "util/misc/uuid.h"

#include "util/net/http_body.h"

#include "util/net/http_multipart_builder.h"

@@ -366,7 +367,7 @@ CrashReportUploadThread::UploadResult CrashReportUploadThread::UploadReport(

HTTPHeaders::value_type content_type =

http_multipart_builder.GetContentType();

http_transport->SetHeader(content_type.first, content_type.second);

- http_transport->SetBodyStream(http_multipart_builder.GetBodyStream().Pass());

+ http_transport->SetBodyStream(http_multipart_builder.GetBodyStream());

// TODO(mark): The timeout should be configurable by the client.

http_transport->SetTimeout(60.0); // 1 minute.

« no previous file with comments | « client/settings.cc ('k') | handler/handler_main.cc » ('j') | no next file with comments »