Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: minidump/minidump_string_writer.cc

Issue 1483073004: Replace use of .Pass() with crashpad::move(). (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: pass: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_string_writer.h" 15 #include "minidump/minidump_string_writer.h"
16 16
17 #include <sys/types.h> 17 #include <sys/types.h>
18 18
19 #include "base/logging.h" 19 #include "base/logging.h"
20 #include "minidump/minidump_writer_util.h" 20 #include "minidump/minidump_writer_util.h"
21 #include "util/file/file_writer.h" 21 #include "util/file/file_writer.h"
22 #include "util/stdlib/move.h"
22 #include "util/numeric/safe_assignment.h" 23 #include "util/numeric/safe_assignment.h"
23 24
24 namespace crashpad { 25 namespace crashpad {
25 namespace internal { 26 namespace internal {
26 27
27 template <typename Traits> 28 template <typename Traits>
28 MinidumpStringWriter<Traits>::MinidumpStringWriter() 29 MinidumpStringWriter<Traits>::MinidumpStringWriter()
29 : MinidumpWritable(), string_base_(new MinidumpStringType()), string_() { 30 : MinidumpWritable(), string_base_(new MinidumpStringType()), string_() {
30 } 31 }
31 32
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 for (const std::string& string : vector) { 115 for (const std::string& string : vector) {
115 AddStringUTF8(string); 116 AddStringUTF8(string);
116 } 117 }
117 } 118 }
118 119
119 template <typename MinidumpStringWriterType> 120 template <typename MinidumpStringWriterType>
120 void MinidumpStringListWriter<MinidumpStringWriterType>::AddStringUTF8( 121 void MinidumpStringListWriter<MinidumpStringWriterType>::AddStringUTF8(
121 const std::string& string_utf8) { 122 const std::string& string_utf8) {
122 auto string_writer = make_scoped_ptr(new MinidumpStringWriterType()); 123 auto string_writer = make_scoped_ptr(new MinidumpStringWriterType());
123 string_writer->SetUTF8(string_utf8); 124 string_writer->SetUTF8(string_utf8);
124 AddChild(string_writer.Pass()); 125 AddChild(crashpad::move(string_writer));
125 } 126 }
126 127
127 template <typename MinidumpStringWriterType> 128 template <typename MinidumpStringWriterType>
128 bool MinidumpStringListWriter<MinidumpStringWriterType>::IsUseful() const { 129 bool MinidumpStringListWriter<MinidumpStringWriterType>::IsUseful() const {
129 return !IsEmpty(); 130 return !IsEmpty();
130 } 131 }
131 132
132 // Explicit template instantiation of the forms of MinidumpStringListWriter<> 133 // Explicit template instantiation of the forms of MinidumpStringListWriter<>
133 // used as type aliases. 134 // used as type aliases.
134 template class MinidumpStringListWriter<MinidumpUTF16StringWriter>; 135 template class MinidumpStringListWriter<MinidumpUTF16StringWriter>;
135 template class MinidumpStringListWriter<MinidumpUTF8StringWriter>; 136 template class MinidumpStringListWriter<MinidumpUTF8StringWriter>;
136 137
137 } // namespace internal 138 } // namespace internal
138 } // namespace crashpad 139 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_simple_string_dictionary_writer_test.cc ('k') | minidump/minidump_system_info_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698