Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: minidump/minidump_crashpad_info_writer.cc

Issue 1483073004: Replace use of .Pass() with crashpad::move(). (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: pass: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « handler/mac/exception_handler_server.cc ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_crashpad_info_writer.h" 15 #include "minidump/minidump_crashpad_info_writer.h"
16 16
17 #include "base/logging.h" 17 #include "base/logging.h"
18 #include "minidump/minidump_module_crashpad_info_writer.h" 18 #include "minidump/minidump_module_crashpad_info_writer.h"
19 #include "minidump/minidump_simple_string_dictionary_writer.h" 19 #include "minidump/minidump_simple_string_dictionary_writer.h"
20 #include "snapshot/process_snapshot.h" 20 #include "snapshot/process_snapshot.h"
21 #include "util/file/file_writer.h" 21 #include "util/file/file_writer.h"
22 #include "util/stdlib/move.h"
22 23
23 namespace crashpad { 24 namespace crashpad {
24 25
25 MinidumpCrashpadInfoWriter::MinidumpCrashpadInfoWriter() 26 MinidumpCrashpadInfoWriter::MinidumpCrashpadInfoWriter()
26 : MinidumpStreamWriter(), 27 : MinidumpStreamWriter(),
27 crashpad_info_(), 28 crashpad_info_(),
28 simple_annotations_(nullptr), 29 simple_annotations_(nullptr),
29 module_list_(nullptr) { 30 module_list_(nullptr) {
30 crashpad_info_.version = MinidumpCrashpadInfo::kVersion; 31 crashpad_info_.version = MinidumpCrashpadInfo::kVersion;
31 } 32 }
(...skipping 12 matching lines...) Expand all
44 45
45 UUID client_id; 46 UUID client_id;
46 process_snapshot->ClientID(&client_id); 47 process_snapshot->ClientID(&client_id);
47 SetClientID(client_id); 48 SetClientID(client_id);
48 49
49 auto simple_annotations = 50 auto simple_annotations =
50 make_scoped_ptr(new MinidumpSimpleStringDictionaryWriter()); 51 make_scoped_ptr(new MinidumpSimpleStringDictionaryWriter());
51 simple_annotations->InitializeFromMap( 52 simple_annotations->InitializeFromMap(
52 process_snapshot->AnnotationsSimpleMap()); 53 process_snapshot->AnnotationsSimpleMap());
53 if (simple_annotations->IsUseful()) { 54 if (simple_annotations->IsUseful()) {
54 SetSimpleAnnotations(simple_annotations.Pass()); 55 SetSimpleAnnotations(crashpad::move(simple_annotations));
55 } 56 }
56 57
57 auto modules = make_scoped_ptr(new MinidumpModuleCrashpadInfoListWriter()); 58 auto modules = make_scoped_ptr(new MinidumpModuleCrashpadInfoListWriter());
58 modules->InitializeFromSnapshot(process_snapshot->Modules()); 59 modules->InitializeFromSnapshot(process_snapshot->Modules());
59 60
60 if (modules->IsUseful()) { 61 if (modules->IsUseful()) {
61 SetModuleList(modules.Pass()); 62 SetModuleList(crashpad::move(modules));
62 } 63 }
63 } 64 }
64 65
65 void MinidumpCrashpadInfoWriter::SetReportID(const UUID& report_id) { 66 void MinidumpCrashpadInfoWriter::SetReportID(const UUID& report_id) {
66 DCHECK_EQ(state(), kStateMutable); 67 DCHECK_EQ(state(), kStateMutable);
67 68
68 crashpad_info_.report_id = report_id; 69 crashpad_info_.report_id = report_id;
69 } 70 }
70 71
71 void MinidumpCrashpadInfoWriter::SetClientID(const UUID& client_id) { 72 void MinidumpCrashpadInfoWriter::SetClientID(const UUID& client_id) {
72 DCHECK_EQ(state(), kStateMutable); 73 DCHECK_EQ(state(), kStateMutable);
73 74
74 crashpad_info_.client_id = client_id; 75 crashpad_info_.client_id = client_id;
75 } 76 }
76 77
77 void MinidumpCrashpadInfoWriter::SetSimpleAnnotations( 78 void MinidumpCrashpadInfoWriter::SetSimpleAnnotations(
78 scoped_ptr<MinidumpSimpleStringDictionaryWriter> simple_annotations) { 79 scoped_ptr<MinidumpSimpleStringDictionaryWriter> simple_annotations) {
79 DCHECK_EQ(state(), kStateMutable); 80 DCHECK_EQ(state(), kStateMutable);
80 81
81 simple_annotations_ = simple_annotations.Pass(); 82 simple_annotations_ = crashpad::move(simple_annotations);
82 } 83 }
83 84
84 void MinidumpCrashpadInfoWriter::SetModuleList( 85 void MinidumpCrashpadInfoWriter::SetModuleList(
85 scoped_ptr<MinidumpModuleCrashpadInfoListWriter> module_list) { 86 scoped_ptr<MinidumpModuleCrashpadInfoListWriter> module_list) {
86 DCHECK_EQ(state(), kStateMutable); 87 DCHECK_EQ(state(), kStateMutable);
87 88
88 module_list_ = module_list.Pass(); 89 module_list_ = crashpad::move(module_list);
89 } 90 }
90 91
91 bool MinidumpCrashpadInfoWriter::Freeze() { 92 bool MinidumpCrashpadInfoWriter::Freeze() {
92 DCHECK_EQ(state(), kStateMutable); 93 DCHECK_EQ(state(), kStateMutable);
93 94
94 if (!MinidumpStreamWriter::Freeze()) { 95 if (!MinidumpStreamWriter::Freeze()) {
95 return false; 96 return false;
96 } 97 }
97 98
98 if (simple_annotations_) { 99 if (simple_annotations_) {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 } 139 }
139 140
140 bool MinidumpCrashpadInfoWriter::IsUseful() const { 141 bool MinidumpCrashpadInfoWriter::IsUseful() const {
141 return crashpad_info_.report_id != UUID() || 142 return crashpad_info_.report_id != UUID() ||
142 crashpad_info_.client_id != UUID() || 143 crashpad_info_.client_id != UUID() ||
143 simple_annotations_ || 144 simple_annotations_ ||
144 module_list_; 145 module_list_;
145 } 146 }
146 147
147 } // namespace crashpad 148 } // namespace crashpad
OLDNEW
« no previous file with comments | « handler/mac/exception_handler_server.cc ('k') | minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698