Replace use of .Pass() with crashpad::move().

util/stdlib/move.h

+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_UTIL_STDLIB_MOVE_H_
+#define CRASHPAD_UTIL_STDLIB_MOVE_H_
+
+#include "util/stdlib/cxx.h"
+
+namespace crashpad {
+
+#if CXX_LIBRARY_VERSION >= 2011
+//! \brief A typedef for std::remove_reference until C++11 library support is
+//     always available.
+using remove_reference = std::remove_reference;

[danakj, 2015/11/30 22:10:26]

Technically I could avoid making this at all if >= 2011. But I didn't like the
idea of sometimes defining a symbol and sometimes not?

[scottmg, 2015/11/30 22:10:50]

FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft
Visual Studio 12.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC
@obj\minidump\crashpad_minidump_test.minidump_thread_writer_test.obj.rsp /c
..\..\minidump\minidump_thread_writer_test.cc
/Foobj\minidump\crashpad_minidump_test.minidump_thread_writer_test.obj
/Fdobj\minidump\crashpad_minidump_test.cc.pdb
d:\src\crashpad\crashpad\util\stdlib\move.h(25) : error C2955:
'std::remove_reference' : use of class template requires template argument list
        c:\program files (x86)\microsoft visual studio
12.0\vc\include\xtr1common(315) : see declaration of 'std::remove_reference'
ninja: build stopped: subcommand failed.

[danakj, 2015/11/30 22:14:45]

mmm.. oh, you can template a typedef as of c++11 apparently. how's this? ^_^'

[scottmg, 2015/11/30 22:19:55]

We win! (Or, it compiles anyway.)

+#else
+//! \brief A replacement for std::remove_reference until C++11 library support
+//     is always available.
+template <class T>
+struct remove_reference { using type = T; };
+template <class T>
+struct remove_reference<T&> { using type = T; };
+#endif  // CXX_LIBRARY_VERSION
+
+
+#if CXX_LIBRARY_VERSION >= 2011
+//! \brief A wrapper around std::move() until C++11 library support is
+//     always available.
+template<typename T>

[Mark Mentovai, 2015/11/30 22:11:41]

I think clang-format likes a space between template and <. Here and on line 46
too.

[danakj, 2015/11/30 22:14:59]

Done.

+typename std::remove_reference<T>::type&& move(T&& t) {
+  return std::move(t);
+}
+#else
+//! \brief A replacement for std::move() until C++11 library support is
+//     always available.
+template<typename T>
+typename remove_reference<T>::type&& move(T&& t) {
+  return static_cast<typename remove_reference<T>::type&&>(t);
+}
+#endif  // CXX_LIBRARY_VERSION
+
+}  // namespace crashpad
+
+#endif  // CRASHPAD_UTIL_STDLIB_MOVE_H_