Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1483053004: Array constructor failed to enter it's function execution context. (Closed)

Created:
5 years ago by mvstanton
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Array constructor failed to enter it's function execution context. This becomes visible if an exception is thrown by the constructor. We do this on "new Array(3.5)", throwing a RangeError. BUG= Committed: https://crrev.com/d2f78c6b7917b89b589e6d10e0282b14b3322e30 Cr-Commit-Position: refs/heads/master@{#32476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/array-constructor.js View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mvstanton
HI Benedikt, here is the Array context issue you noticed a week or so ago, ...
5 years ago (2015-12-01 17:05:27 UTC) #2
Benedikt Meurer
lgtm
5 years ago (2015-12-01 18:15:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483053004/1
5 years ago (2015-12-01 18:28:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 18:42:43 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 18:43:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2f78c6b7917b89b589e6d10e0282b14b3322e30
Cr-Commit-Position: refs/heads/master@{#32476}

Powered by Google App Engine
This is Rietveld 408576698