Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1483003002: Revert of Introduce instance type for transition arrays. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Introduce instance type for transition arrays. (patchset #6 id:100001 of https://codereview.chromium.org/1480873003/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Introduce instance type for transition arrays. > > The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. > > BUG=chromium:554488 > LOG=NO > > Committed: https://crrev.com/026095a3c7932573e1810b8064ec3008ed696601 > Cr-Commit-Position: refs/heads/master@{#32396} TBR=mlippautz@chromium.org,jkummerow@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:554488 Committed: https://crrev.com/38bf70b9cd2a07b99ac0c0b7eda111849e79c146 Cr-Commit-Position: refs/heads/master@{#32404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -188 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap/heap.h View 5 chunks +0 lines, -13 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +2 lines, -29 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/objects-visiting.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +0 lines, -21 lines 0 comments Download
M src/objects.h View 4 chunks +3 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/objects-inl.h View 5 chunks +8 lines, -12 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/transitions.h View 4 chunks +5 lines, -18 lines 0 comments Download
M src/transitions.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/types.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Hannes Payer (out of office)
Created Revert of Introduce instance type for transition arrays.
5 years ago (2015-11-30 13:03:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483003002/1
5 years ago (2015-11-30 13:03:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 13:04:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/38bf70b9cd2a07b99ac0c0b7eda111849e79c146 Cr-Commit-Position: refs/heads/master@{#32404}
5 years ago (2015-11-30 13:04:17 UTC) #5
Hannes Payer (out of office)
5 years ago (2015-12-03 13:17:58 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1500623002/ by hpayer@chromium.org.

The reason for reverting is: Suspect for crashing found, relanding for canary
coverage..

Powered by Google App Engine
This is Rietveld 408576698