Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: pkg/compiler/lib/src/common/tasks.dart

Issue 1482983002: Avoid using dart:developer from the compiler. (Closed) Base URL: git@github.com:dart-lang/sdk.git@_temporary_fletch_patches
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/common/tasks.dart
diff --git a/pkg/compiler/lib/src/common/tasks.dart b/pkg/compiler/lib/src/common/tasks.dart
index 737c2a9ce0e546be1e9105a12ef1b94901dee400..8a7dcb3283802fc9549be28405fa7063db6dd94c 100644
--- a/pkg/compiler/lib/src/common/tasks.dart
+++ b/pkg/compiler/lib/src/common/tasks.dart
@@ -4,9 +4,6 @@
library dart2js.common.tasks;
-import 'dart:developer' show
- UserTag;
-
import '../common.dart';
import '../compiler.dart' show
Compiler;
@@ -25,7 +22,6 @@ class DeferredTask {
class CompilerTask {
final Compiler compiler;
final Stopwatch watch;
- UserTag profilerTag;
final Map<String, GenericTask> _subtasks = <String, GenericTask>{};
CompilerTask(Compiler compiler)
@@ -45,11 +41,6 @@ class CompilerTask {
return total;
}
- UserTag getProfilerTag() {
- if (profilerTag == null) profilerTag = new UserTag(name);
- return profilerTag;
- }
-
measure(action()) {
// In verbose mode when watch != null.
if (watch == null) return action();
@@ -58,12 +49,10 @@ class CompilerTask {
compiler.measuredTask = this;
if (previous != null) previous.watch.stop();
watch.start();
- UserTag oldTag = getProfilerTag().makeCurrent();
try {
return action();
} finally {
watch.stop();
- oldTag.makeCurrent();
if (previous != null) previous.watch.start();
compiler.measuredTask = previous;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698