Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1482973003: Revert of Do not remove write barriers for stores of old space references in most recent old space allocation. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Do not remove write barriers for stores of old space references in most recent old space allocation. (patchset #1 id:1 of https://codereview.chromium.org/1478113002/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Do not remove write barriers for stores of old space references in most recent old space allocation. > > BUG=chromium:561449 > LOG=n > > Committed: https://crrev.com/369778ec55a63ebe51e8fa8497edb5b681069b9b > Cr-Commit-Position: refs/heads/master@{#32368} TBR=ulan@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:561449 Committed: https://crrev.com/da56525478f1820e3da629576ab61acc5f84daac Cr-Commit-Position: refs/heads/master@{#32406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Hannes Payer (out of office)
Created Revert of Do not remove write barriers for stores of old space references in ...
5 years ago (2015-11-30 13:06:02 UTC) #1
Hannes Payer (out of office)
5 years ago (2015-12-03 12:23:28 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1493313002/ by hpayer@chromium.org.

The reason for reverting is: Suspect for crashing found, relanding for canary
coverage..

Powered by Google App Engine
This is Rietveld 408576698