Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1482963003: Clean up ArchDefaultRegisterConfiguration. (Closed)

Created:
5 years ago by bbudge
Modified:
5 years ago
Reviewers:
titzer, Mircea Trofin, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up ArchDefaultRegisterConfiguration. Remove two unused fields. Define register codes the same way register names are defined and eliminate static methods. #error if target isn't defined. LOG=N BUG=v8:4124 Committed: https://crrev.com/6aa9b10faf64edc1923967212c313b339c18a9a9 Cr-Commit-Position: refs/heads/master@{#32467}

Patch Set 1 #

Patch Set 2 : Fix ARM build. #

Patch Set 3 : #

Patch Set 4 : IsAllocatable*Code methods, instead of exposing masks. #

Patch Set 5 : Leave masks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -55 lines) Patch
M src/register-configuration.cc View 1 2 3 2 chunks +49 lines, -55 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bbudge
A little cleanup before I change how aliasing is defined.
5 years ago (2015-12-01 01:31:11 UTC) #4
Mircea Trofin
On 2015/12/01 01:31:11, bbudge wrote: > A little cleanup before I change how aliasing is ...
5 years ago (2015-12-01 02:54:14 UTC) #5
titzer
lgtm
5 years ago (2015-12-01 10:08:13 UTC) #6
danno
On 2015/12/01 10:08:13, titzer wrote: > lgtm lgtm
5 years ago (2015-12-01 10:24:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482963003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482963003/80001
5 years ago (2015-12-01 14:11:09 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-01 14:18:18 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 14:18:58 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6aa9b10faf64edc1923967212c313b339c18a9a9
Cr-Commit-Position: refs/heads/master@{#32467}

Powered by Google App Engine
This is Rietveld 408576698