Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 1482953002: Drop dependency on LayoutObject in fetch/ (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
f(malita), fs
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, jchaffraix+rendering, leviw+renderwatch, loading-reviews+fetch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop dependency on LayoutObject in fetch/ Move out code from ImageResource depending on LayoutObject. Instead request pre-caching explictly at the three places that currently has reason for doing so. The pre-caching itself is moved to BitmapImage and made part of Image::currentFrameKnownToBeOpaque as a special metadata mode. BUG=559131 Committed: https://crrev.com/21dda4ff240c71b4ec14580da73a09405857b0dc Cr-Commit-Position: refs/heads/master@{#362127}

Patch Set 1 #

Patch Set 2 : Move pre-caching into BitmapImage #

Patch Set 3 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M third_party/WebKit/Source/core/fetch/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DragImageTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482953002/1
5 years ago (2015-11-30 09:05:42 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/85767)
5 years ago (2015-11-30 09:17:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482953002/20001
5 years ago (2015-11-30 10:44:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/63277)
5 years ago (2015-11-30 10:57:07 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482953002/40001
5 years ago (2015-11-30 11:03:51 UTC) #11
davve
Another attempt to get rid of that last LayoutObject tracing dependency in fetch/.
5 years ago (2015-11-30 11:05:28 UTC) #13
fs
lgtm
5 years ago (2015-11-30 11:25:16 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 12:19:30 UTC) #16
f(malita)
lgtm
5 years ago (2015-11-30 14:14:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482953002/40001
5 years ago (2015-11-30 14:17:09 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-30 14:22:18 UTC) #21
commit-bot: I haz the power
5 years ago (2015-11-30 14:24:01 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/21dda4ff240c71b4ec14580da73a09405857b0dc
Cr-Commit-Position: refs/heads/master@{#362127}

Powered by Google App Engine
This is Rietveld 408576698